code review 12082045: net: add missing SetKeepAlivePeriod for Plan 9

net: add missing SetKeepAlivePeriod for Plan 9

[mikio, 2013-07-30 05:50:01]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-07-30 06:21:46]

LGTM. Thanks

On Tue, Jul 30, 2013 at 3:50 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: add missing SetKeepAlivePeriod for Plan 9
>
> Please review this at https://codereview.appspot.com/12082045/
>
> Affected files:
>   M src/pkg/net/tcpsock_plan9.go
>
>
> Index: src/pkg/net/tcpsock_plan9.go
> ===================================================================
> --- a/src/pkg/net/tcpsock_plan9.go
> +++ b/src/pkg/net/tcpsock_plan9.go
> @@ -65,6 +65,11 @@
>         return syscall.EPLAN9
>  }
>
> +// SetKeepAlivePeriod sets period between keep alives.
> +func (c *TCPConn) SetKeepAlivePeriod(d time.Duration) error {
> +       return syscall.EPLAN9
> +}
> +
>  // SetNoDelay controls whether the operating system should delay
>  // packet transmission in hopes of sending fewer packets (Nagle's
>  // algorithm).  The default is true (no delay), meaning that data is
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[mikio, 2013-07-30 07:33:49]

For the record; just submitted but got "ssl.SSLError: The read
operation timed out" during the submission process. Looks like build
dashboard is fine.