Issue 12050047: Template content diff

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12050047: Template content diff (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by ana.balica

Modified:
11 years, 7 months ago

Reviewers:
thomas.j.waldmann, waldi

Visibility:
Public.

More Reviews

Description

content_diff is rendered using the return value from MoinMoin/util/diff_text.py diff() function by iterating over the lines.

Patch Set 2 : Fix table row width property #

Patch Set 4 : Remove default font-size #

Total comments: 2

Patch Set 5 : Use relative sizes and del/ins tags #

Total comments: 2

Patch Set 6 : Fix indentation #

Patch Set 7 : Set vertical align top #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	A	MoinMoin/templates/mail/content_diff.html	View	1 2 3 4 5 6	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

https://codereview.appspot.com/12050047/diff/10001/MoinMoin/templates/mail/content_diff.html File MoinMoin/templates/mail/content_diff.html (right): https://codereview.appspot.com/12050047/diff/10001/MoinMoin/templates/mail/content_diff.html#newcode2 MoinMoin/templates/mail/content_diff.html:2: <table border="0" cellpadding="0" cellspacing="0" style="margin:0; padding:10px; no absolute size ...

11 years, 9 months ago (2013-08-11 11:25:41 UTC) #1

Thomas.J.Waldmann

https://codereview.appspot.com/12050047/diff/14001/MoinMoin/templates/mail/content_diff.html File MoinMoin/templates/mail/content_diff.html (right): https://codereview.appspot.com/12050047/diff/14001/MoinMoin/templates/mail/content_diff.html#newcode29 MoinMoin/templates/mail/content_diff.html:29: </table> how does that look like?

11 years, 9 months ago (2013-08-12 19:58:20 UTC) #2

ana.balica

11 years, 9 months ago (2013-08-12 20:11:40 UTC) #3

https://codereview.appspot.com/12050047/diff/14001/MoinMoin/templates/mail/co...
File MoinMoin/templates/mail/content_diff.html (right):

https://codereview.appspot.com/12050047/diff/14001/MoinMoin/templates/mail/co...
MoinMoin/templates/mail/content_diff.html:29: </table>
On 2013/08/12 19:58:20, Thomas.J.Waldmann wrote:
> how does that look like?

http://imagebin.org/index.php?mode=image&id=267310

The greyish table below the Content header.

Expand All Messages | Collapse All Messages