Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 1204044: Add missing semicolons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by chirag
Modified:
15 years, 7 months ago
Reviewers:
johnfargo, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Simple change to add missing semicolons where needed.

Patch Set 1 #

Patch Set 2 : Fix patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
features/src/main/javascript/features/core.io/io.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/core.log/log.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/flash/flash.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-data-context/datacontext.js View 2 chunks +2 lines, -2 lines 0 comments Download
features/src/main/javascript/features/opensocial-templates/compiler.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/opensocial-templates/util.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/osapi/osapi.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/rpc/fe.transport.js View 1 chunk +2 lines, -2 lines 0 comments Download
features/src/main/javascript/features/rpc/nix.transport.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/rpc/rmr.transport.js View 2 chunks +3 lines, -3 lines 0 comments Download
features/src/main/javascript/features/rpc/rpc.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
chirag
15 years, 10 months ago (2010-05-19 22:39:47 UTC) #1
chirag
Fix patch
15 years, 10 months ago (2010-05-19 22:46:09 UTC) #2
johnfargo
15 years, 9 months ago (2010-05-24 20:34:04 UTC) #3
LGTM

Though some of the patches (again?) have chunk mismatches :(

On 2010/05/19 22:46:09, chirag wrote:
> Fix patch
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b