Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 12032043: Corrects bounding box for longa (Issue 826) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by PhilEHolmes
Modified:
6 years, 1 month ago
Reviewers:
email, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Corrects bounding box for longa (Issue 826) Fixes bounding boxes for breves, improves longas (Issue 3480)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M mf/feta-noteheads.mf View 6 chunks +18 lines, -10 lines 1 comment Download

Messages

Total messages: 2
dak
https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf#newcode116 mf/feta-noteheads.mf:116: final_line_length := quanted_line_length * staff_space; This is rather hard ...
6 years, 1 month ago (2013-07-29 17:08:00 UTC) #1
email_philholmes.net
6 years, 1 month ago (2013-07-29 20:07:43 UTC) #2
----- Original Message ----- 
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Monday, July 29, 2013 6:08 PM
Subject: Corrects bounding box for longa (Issue 826) (issue 12032043)


>
> https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf
> File mf/feta-noteheads.mf (right):
>
>
https://codereview.appspot.com/12032043/diff/1/mf/feta-noteheads.mf#newcode116
> mf/feta-noteheads.mf:116: final_line_length := quanted_line_length *
> staff_space;
> This is rather hard to figure out.  Why don't you make
> define_pixels (final_line_length)
> and calculate final_line_length# as quanted_line_length * staff_space# ?
>
> The problem is that it is very hard to figure out the relation between
> boxtop# and final_line_length.
>
> https://codereview.appspot.com/12032043/

I'm not particularly confident with metafont code, and so generally try to 
make the minimum change necessary to effect the desired result. That said, I 
think final_line_length is a spurious variable, and so if you think the 
relationship between it and the boxxxx variables is not clear, would suggest 
deleting that variable.

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b