Template meta diff

meta diff is rendered using the output from MoinMoin/util/diff_datastructure.py diff function - a list of tuples with changes

[Thomas.J.Waldmann, 2013-07-31 14:47:51]

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
File MoinMoin/templates/mail/meta_diff.html (right):

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
MoinMoin/templates/mail/meta_diff.html:8: <tr style="color:#991111;
height:16px;">
px? how does this work with high-dpi displays?

[waldi, 2013-07-31 14:52:06]

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
File MoinMoin/templates/mail/meta_diff.html (right):

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
MoinMoin/templates/mail/meta_diff.html:6: <tr style="color:#00B000;
height:16px;">
There are del and ins tags. And don't use absolute sizes.

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
MoinMoin/templates/mail/meta_diff.html:10: <td style="font-family:monospace;
width:15px;">{{ change[0] }}</td>
Duplicate font-family.

[ana.balica, 2013-07-31 15:51:03]

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
File MoinMoin/templates/mail/meta_diff.html (right):

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
MoinMoin/templates/mail/meta_diff.html:6: <tr style="color:#00B000;
height:16px;">
On 2013/07/31 14:52:06, waldi wrote:
> There are del and ins tags. And don't use absolute sizes.

Are you suggesting creating constants inside the template?
{% set INSERT = "+" %} ?

https://codereview.appspot.com/12024044/diff/3001/MoinMoin/templates/mail/met...
MoinMoin/templates/mail/meta_diff.html:10: <td style="font-family:monospace;
width:15px;">{{ change[0] }}</td>
On 2013/07/31 14:52:06, waldi wrote:
> Duplicate font-family.

yes. each table cell has inline style (font-family in this case). otherwise it
won't render correctly.

[Thomas.J.Waldmann, 2013-08-12 19:56:25]

https://codereview.appspot.com/12024044/diff/17001/MoinMoin/templates/mail/me...
File MoinMoin/templates/mail/meta_diff.html (right):

https://codereview.appspot.com/12024044/diff/17001/MoinMoin/templates/mail/me...
MoinMoin/templates/mail/meta_diff.html:27: {% endmacro %}
how does that look like?

[ana.balica, 2013-08-12 20:10:03]

https://codereview.appspot.com/12024044/diff/17001/MoinMoin/templates/mail/me...
File MoinMoin/templates/mail/meta_diff.html (right):

https://codereview.appspot.com/12024044/diff/17001/MoinMoin/templates/mail/me...
MoinMoin/templates/mail/meta_diff.html:27: {% endmacro %}
On 2013/08/12 19:56:26, Thomas.J.Waldmann wrote:
> how does that look like?

http://imagebin.org/index.php?mode=image&id=267310

Below the Metadata header, the table with no borders and grey background.
I can also send you a full stack of images with tests for about 30 mail clients
(including mobile ones).