Issue 325 - Remove discovery and codegen

Issue 325 - Remove discovery and codegen

[peleyal, 2013-07-29 11:49:08]

Hi Nick,

I know it's a huge CL, but if you look at it carefully you will see that most of
the files were deleted.

This is a change which removes all discovery and codegen unnecessary code as the
final step before we will release a new version with the codegen templates
system. 

I'll submit this CL after your approval and after we are ready to add csharp to
the generate page
https://google-api-client-libraries.appspot.com/generate

Thanks!

[ngmiceli, 2013-08-06 03:42:05]

It's somewhat hard to navigate these changes without being able to view them in
VS, but unfortunately this change is "too large to download". It looks good from
my lookover, and I'll give you approval if that's all you wanted, but if you'd
like a review in some more depth then could you please email me a patch file or
a zip of the new library?

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Http/C...
File Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Http/C...
Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs:48: private static
readonly string ApiVersion = Google.Apis.Util.Utilities.GetLibraryVersion();
Why this change?

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Reques...
File Src/GoogleApis/Apis/Requests/RequestError.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Reques...
Src/GoogleApis/Apis/Requests/RequestError.cs:60: if (Errors == null ||
Errors.Count == 0)
I prefer the original here...

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Util/U...
File Src/GoogleApis/Apis/Util/Utilities.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Util/U...
Src/GoogleApis/Apis/Util/Utilities.cs:36: return
Regex.Match(typeof(Utilities).Assembly.FullName,
"Version=([\\d\\.]+)").Groups[1].ToString();
Does this logic have a unit test?

[peleyal, 2013-08-06 14:46:57]

I share two files with you
default.zip which contains the solution and the new Tools folder in the default
repository

default-src.zip which contains the Src folder in the default repository.

Let me know,
Eyal

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Http/C...
File Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Http/C...
Src/GoogleApis/Apis/Http/ConfigurableMessageHandler.cs:48: private static
readonly string ApiVersion = Google.Apis.Util.Utilities.GetLibraryVersion();
There were two Utilities classes before this change. 
One of them were in Google.Apis namespace while the other in Google.Apis.Util

I removed the first one, and because it's in a different namespace I should use
the full name. I didn't want to use Google.Apis.Util (using Google.Apis.Util) so
I have the full name here

On 2013/08/06 03:42:06, ngmiceli wrote:
> Why this change?

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Reques...
File Src/GoogleApis/Apis/Requests/RequestError.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Reques...
Src/GoogleApis/Apis/Requests/RequestError.cs:60: if (Errors == null ||
Errors.Count == 0)
On 2013/08/06 03:42:06, ngmiceli wrote:
> I prefer the original here...

Done.

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Util/U...
File Src/GoogleApis/Apis/Util/Utilities.cs (right):

https://codereview.appspot.com/12020043/diff/30012/Src/GoogleApis/Apis/Util/U...
Src/GoogleApis/Apis/Util/Utilities.cs:36: return
Regex.Match(typeof(Utilities).Assembly.FullName,
"Version=([\\d\\.]+)").Groups[1].ToString();
I'll open an issue for that in our issue tracker.
It was before this change, I just moved it from other class
On 2013/08/06 03:42:06, ngmiceli wrote:
> Does this logic have a unit test?

[ngmiceli, 2013-08-07 21:03:27]

LGTM
It's freggin beautiful. Now go away. :)