Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(429)

Issue 120061: Issue 1063: onload doesn't always fire (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1063 1. the testbed doesn't pass the extra arg to HtmlEmitter, so onload never fires in the testbed. 2. even when onload does fire, it sometimes doesn't fire. cajole this: <div>foo</div> <script> window.onload = function(){cajita.log(1);}; 1; </script> note that in the cajoled output, there are no calls to emitter___.signalLoaded(); Fixed SafeHtmlMaker to make sure that emitter___.signalLoaded() is always present when there is user supplied JS inline in the input. Submitted @3736

Patch Set 1 #

Patch Set 2 : Issue 1063: onload doesn't always fire #

Patch Set 3 : Issue 1063: onload doesn't always fire #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/com/google/caja/demos/applet/testbed.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/templates/SafeHtmlMaker.java View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/com/google/caja/service/CajolingServiceTest.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 8 months ago (2009-09-22 00:56:12 UTC) #1
Jasvir
16 years, 8 months ago (2009-09-23 20:20:18 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b