Issue 11989043: code review 11989043: cmd/6g, cmd/8g: remove a useless temporary in comparison.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11989043: code review 11989043: cmd/6g, cmd/8g: remove a useless temporary in comparison.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by remyoudompheng

Modified:
11 years, 11 months ago

Reviewers:
DMorsing, rsc, golang-codereviews

CC:
golang-codereviews

Visibility:
Public.

Description

cmd/6g, cmd/8g: remove a useless temporary in comparison. This temporary was used to work around cases where the frontend would emit comparison between constants (revision 5327829ff1e4).

Patch Set 2 : diff -r 2fe813f4f3c2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2fe813f4f3c2 https://go.googlecode.com/hg/ #

Total comments: 2

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/cmd/6g/cgen.c	View	1	1 chunk	+5 lines, -2 lines	2 comments	Download
	M	src/cmd/8g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2013-07-28 15:50:30 UTC) #1

rsc

https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c File src/cmd/6g/cgen.c (right): https://codereview.appspot.com/11989043/diff/2002/src/cmd/6g/cgen.c#newcode1241 src/cmd/6g/cgen.c:1241: tempname(&n1, nl->type); This used to be a register. Why ...

12 years, 5 months ago (2013-07-29 17:13:31 UTC) #2

DMorsing

12 years, 5 months ago (2013-07-29 18:22:43 UTC) #3

R=close
(assuming this timed out)

Expand All Messages | Collapse All Messages