Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 11987: Fix bug: parser fails to parse expressions properly when newline precedes comma (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 2 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

There was an unnecessary semicolon insertion check in parseExpressionInt in the JS Parser that caused it to fail on the following code (function () { return 1 , 2; })

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bug: parser fails to parse expressions properly when newline precedes comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/com/google/caja/parser/js/Parser.java View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/js/ParserTest.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
MikeSamuel
17 years, 2 months ago (2009-01-27 01:50:17 UTC) #1
Jasvir
http://codereview.appspot.com/11987/diff/1/3 File src/com/google/caja/parser/js/Parser.java (right): http://codereview.appspot.com/11987/diff/1/3#newcode698 Line 698: // Handle comma operator Please add a comment ...
17 years, 2 months ago (2009-01-27 02:08:34 UTC) #2
MikeSamuel
http://codereview.appspot.com/11987/diff/1/3 File src/com/google/caja/parser/js/Parser.java (right): http://codereview.appspot.com/11987/diff/1/3#newcode698 Line 698: // Handle comma operator On 2009/01/27 02:08:34, jasvir ...
17 years, 2 months ago (2009-01-27 02:22:59 UTC) #3
Jasvir
LGTM (Thank you for the comprehensive ParserTests. The parser is very complicated - I believe ...
17 years, 2 months ago (2009-01-27 05:30:04 UTC) #4
MikeSamuel
17 years, 2 months ago (2009-01-27 05:48:23 UTC) #5
@3210
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b