Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 11963043: Schema support for CSS 3 Transforms (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by MikeSamuel
Modified:
12 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://dev.w3.org/csswg/css-transforms/ > CSS Transforms Level 1 > The CSS visual formatting model describes a coordinate system within > each element is positioned. Positions and sizes in this coordinate > space can be thought of as being expressed in pixels, starting in the > origin of point with positive values proceeding to the right and down. > This coordinate space can be modified with the ‘transform’ > property. Using transform, elements can be translated, rotated and > scaled in two or three dimensional space. > Additional properties make working with transforms easier, and allow > the author to control how nested three-dimensional transforms > interact. --- Submitted @ r5513

Patch Set 1 #

Total comments: 2

Patch Set 2 : Schema support for CSS 3 Transforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 2 chunks +2 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/css/CssSchema.java View 1 chunk +10 lines, -1 line 0 comments Download
M src/com/google/caja/lang/css/css-extensions-defs.json View 1 4 chunks +75 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/css/css-extensions-whitelist.json View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
MikeSamuel
12 years, 7 months ago (2013-07-27 07:05:17 UTC) #1
felix8a
lgtm except for the wrong definition of <translation-value> https://codereview.appspot.com/11963043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json File src/com/google/caja/lang/css/css-extensions-defs.json (right): https://codereview.appspot.com/11963043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode776 src/com/google/caja/lang/css/css-extensions-defs.json:776: "source": ...
12 years, 7 months ago (2013-07-27 07:32:50 UTC) #2
MikeSamuel
http://dev.w3.org/csswg/css-transforms/ > CSS Transforms Level 1 > The CSS visual formatting model describes a coordinate ...
12 years, 7 months ago (2013-07-27 15:51:18 UTC) #3
MikeSamuel
12 years, 7 months ago (2013-07-27 15:52:28 UTC) #4
https://codereview.appspot.com/11963043/diff/1/src/com/google/caja/lang/css/c...
File src/com/google/caja/lang/css/css-extensions-defs.json (right):

https://codereview.appspot.com/11963043/diff/1/src/com/google/caja/lang/css/c...
src/com/google/caja/lang/css/css-extensions-defs.json:776: "source":
"http://dev.w3.org/csswg/css-transforms/#svg-transform-value"
On 2013/07/27 07:32:50, felix8a wrote:
> this is the wrong section, this is talking about deprecated syntax in the svg
> transform attribute and confusingly uses a "<translation-value>" that's
> different from the css meaning of <translation-value>.
> 
> css <translation-value> should have the signature
>   "<percentage> | <length>"
> and it's described here:
>   http://dev.w3.org/csswg/css-transforms/#transform-functions

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b