Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(289)

Issue 11938045: Pass ID suffix to sanitizeCssProperty for use with <global-name>s. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by MikeSamuel
Modified:
12 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This supercedes CL 11883043 and just adds an optional parameter to sanitizeCssProperty so that we can use the proper ID suffix with global names like "foo" in p { animation-name: foo; animation-... } @keyframes foo { ... } ---- Submitted @r5511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/html-emitter.js View 1 chunk +5 lines, -3 lines 0 comments Download
M src/com/google/caja/plugin/html-sanitizer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/sanitizecss.js View 9 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 4
MikeSamuel
12 years, 7 months ago (2013-07-26 20:42:37 UTC) #1
felix8a
lgtm, but doesn't this need a testcase change too?
12 years, 7 months ago (2013-07-26 20:50:19 UTC) #2
MikeSamuel
On 2013/07/26 20:50:19, felix8a wrote: > lgtm, but doesn't this need a testcase change too? ...
12 years, 7 months ago (2013-07-26 21:06:49 UTC) #3
felix8a
12 years, 7 months ago (2013-07-26 21:20:31 UTC) #4
On 2013/07/26 21:06:49, MikeSamuel wrote:
> On 2013/07/26 20:50:19, felix8a wrote:
> > lgtm, but doesn't this need a testcase change too?
> 
> No.  The testcase from the prior CL already passes the ID suffix to
> sanitizeStylesheet which faithfully forwards it.

ah, right, ok.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b