Issue 11936043: Add comment view (+addcomment) and UI form.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11936043: Add comment view (+addcomment) and UI form.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by spy

Modified:
11 years, 8 months ago

Reviewers:
thomas.j.waldmann, ReimarBauer

Visibility:
Public.

More Reviews

Description

Add comment view (+addcomment) and UI form.

Patch Set 1 #

Total comments: 3

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -0 lines)			Patch
M	MoinMoin/apps/frontend/__init__.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	MoinMoin/apps/frontend/comment_views.py	View	1 chunk	+63 lines, -0 lines	3 comments	Download
M	MoinMoin/apps/frontend/views.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/items/__init__.py	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	MoinMoin/items/comment.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/templates/comment/utils.html	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/foobar/templates/show.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ReimarBauer

looked quickly on it, have you a practical test done? https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment_views.py File MoinMoin/apps/frontend/comment_views.py (right): https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment_views.py#newcode1 ...

11 years, 8 months ago (2013-07-27 07:48:36 UTC) #1

spy

answered https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment_views.py File MoinMoin/apps/frontend/comment_views.py (right): https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment_views.py#newcode1 MoinMoin/apps/frontend/comment_views.py:1: # Copyright: 2013 MoinMoin:PavelSviderski On 2013/07/27 07:48:36, ReimarBauer ...

11 years, 8 months ago (2013-07-28 15:33:05 UTC) #2

Thomas.J.Waldmann

11 years, 8 months ago (2013-07-29 22:59:31 UTC) #3

https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment...
File MoinMoin/apps/frontend/comment_views.py (right):

https://codereview.appspot.com/11936043/diff/1/MoinMoin/apps/frontend/comment...
MoinMoin/apps/frontend/comment_views.py:57: abort(403)
no better way than to abort?

Expand All Messages | Collapse All Messages