Add a PDB string table writer.

Add a PDB string table writer.

A string table is found in the name stream and in the EC info header of the debug info stream of a PDB file.

This CL also creates the PDB writer project.

BUG=
R=chrisha@chromium.org, sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2205

[fdoray, 2014-07-30 15:37:38]

Could you review this CL?
Thanks.

[Sébastien Marchand, 2014-07-30 17:05:36]

lgtm with a few nits.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.cc (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:16: //    uint32
signature: Equal to kPdbStringTableSignature.
There's no particular rule for this kind of comment, but if your plan was to
indent at +4 then there's a missing space.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:45: }
}  // namespace

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.h (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.h:31: //    position.
Indent + 1.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_writer.gyp (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_writer.gyp:30:
'<(src)/syzygy/common/common.gyp:common_lib',
Switch this line and the previous one (alpha order).

[Sébastien Marchand, 2014-07-30 17:11:13]

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.h (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.h:25: class
WritablePdbStream;
Add a '// Forward declarations.' comment on top of this line.

[fdoray, 2014-07-30 17:29:52]

I addressed all comments from Sebastien.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.cc (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:16: //    uint32
signature: Equal to kPdbStringTableSignature.
On 2014/07/30 17:05:35, Sébastien Marchand wrote:
> There's no particular rule for this kind of comment, but if your plan was to
> indent at +4 then there's a missing space. 

Done.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:45: }
On 2014/07/30 17:05:35, Sébastien Marchand wrote:
> }  // namespace

Done.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.h (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.h:25: class
WritablePdbStream;
On 2014/07/30 17:11:13, Sébastien Marchand wrote:
> Add a '// Forward declarations.' comment on top of this line.

Done.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.h:31: //    position.
On 2014/07/30 17:05:35, Sébastien Marchand wrote:
> Indent + 1.

Done.

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_writer.gyp (right):

https://codereview.appspot.com/119350043/diff/20001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_writer.gyp:30:
'<(src)/syzygy/common/common.gyp:common_lib',
On 2014/07/30 17:05:36, Sébastien Marchand wrote:
> Switch this line and the previous one (alpha order).

Done.

[chrisha, 2014-07-30 17:57:48]

Another nit... otherwise, lgtm.

https://codereview.appspot.com/119350043/diff/40001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.cc (right):

https://codereview.appspot.com/119350043/diff/40001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:43:
COMPILE_ASSERT_IS_POD_OF_SIZE(StringTableHeader, 12);
This is useful information, and could be declared more centrally in pdb_data.h.

[fdoray, 2014-07-30 20:06:06]

https://codereview.appspot.com/119350043/diff/40001/syzygy/experimental/pdb_w...
File syzygy/experimental/pdb_writer/pdb_string_table_writer.cc (right):

https://codereview.appspot.com/119350043/diff/40001/syzygy/experimental/pdb_w...
syzygy/experimental/pdb_writer/pdb_string_table_writer.cc:43:
COMPILE_ASSERT_IS_POD_OF_SIZE(StringTableHeader, 12);
On 2014/07/30 17:57:48, chrisha wrote:
> This is useful information, and could be declared more centrally in
pdb_data.h.

Done.

[fdoray, 2014-07-30 20:06:54]

Committed patchset #5 manually as r2205.