Issue 11916046: Made multiple calls to ShInitialize not assert.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11916046: Made multiple calls to ShInitialize not assert. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Alok Priyadarshi

Modified:
10 years, 8 months ago

Reviewers:
kbr1, apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject@master

Visibility:
Public.

More Reviews

Description

Made multiple calls to ShInitialize not assert. BUG=456 R=apatrick@chromium.org, kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=b93f84a

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/ShaderLang.cpp	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

LGTM if this works properly. Also please double-check the build revision.

10 years, 8 months ago (2013-08-01 23:00:22 UTC) #2

Alok Priyadarshi

10 years, 8 months ago (2013-08-01 23:02:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as rb93f84a (presubmit successful).

Expand All Messages | Collapse All Messages