Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2850)

Issue 11901044: tool: add "address" command to print D-Bus address (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Daiki Ueno
Modified:
10 years, 11 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

tool: add "address" command to print D-Bus address This would be helpful to debug with dbus-monitor. Instead of: $ . .config/ibus/bus/* $ dbus-monitor --address $IBUS_ADDRESS ... one can do: $ dbus-monitor --address $(ibus address) ... This patch also adds help message to each sub-command. BUG= Committed: 1f2a94e

Patch Set 1 #

Total comments: 1

Patch Set 2 : use ibus_get_address() instead of D-Bus protocol #

Patch Set 3 : fix manpage typo #

Patch Set 4 : mention the standard component directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M tools/ibus.1.in View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M tools/main.vala View 1 3 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 5
Daiki Ueno
10 years, 11 months ago (2013-07-26 07:53:16 UTC) #1
Peng
https://codereview.appspot.com/11901044/diff/1/tools/main.vala File tools/main.vala (right): https://codereview.appspot.com/11901044/diff/1/tools/main.vala#newcode332 tools/main.vala:332: GLib.Intl.textdomain(Config.GETTEXT_PACKAGE); Could you please explain why add this? Thanks.
10 years, 11 months ago (2013-07-26 14:33:42 UTC) #2
Daiki Ueno
On 2013/07/26 14:33:42, Peng wrote: > https://codereview.appspot.com/11901044/diff/1/tools/main.vala > File tools/main.vala (right): > > https://codereview.appspot.com/11901044/diff/1/tools/main.vala#newcode332 > ...
10 years, 11 months ago (2013-07-27 00:07:51 UTC) #3
Peng
On 2013/07/27 00:07:51, Daiki Ueno wrote: > On 2013/07/26 14:33:42, Peng wrote: > > https://codereview.appspot.com/11901044/diff/1/tools/main.vala ...
10 years, 11 months ago (2013-07-27 02:43:34 UTC) #4
Daiki Ueno
10 years, 11 months ago (2013-08-01 14:29:52 UTC) #5
Come to think of it, ibus_get_address() can be directly used instead of
ibus_bus_get_ibus_property(..., "Address").  I'll push the second patchset.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b