Issue 118830043: Enhance UI to add engines on ibus-setup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118830043: Enhance UI to add engines on ibus-setup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by fujiwara

Modified:
9 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Enhance UI to add engines on ibus-setup BUG=rhbz#803583 TEST=setup

Patch Set 2 : Updated with message #3. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+399 lines, -14 lines)			Patch
M	po/POTFILES.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	setup/Makefile.am	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A	setup/enginedialog.py	View	1	1 chunk	+365 lines, -0 lines	0 comments	Download
M	setup/enginetreeview.py	View		2 chunks	+2 lines, -10 lines	0 comments	Download
M	setup/main.py	View		5 chunks	+28 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

On 2014/07/17 08:55:18, fujiwara wrote: I added enginedialog.py as GPL 2.0 to follow gnome-control-center.

9 years, 11 months ago (2014-07-17 08:56:29 UTC) #2

Peng

lgtm https://codereview.appspot.com/118830043/diff/1/setup/enginedialog.py File setup/enginedialog.py (right): https://codereview.appspot.com/118830043/diff/1/setup/enginedialog.py#newcode52 setup/enginedialog.py:52: A suggestion. Using two empty lines between functions. ...

9 years, 11 months ago (2014-07-18 02:14:30 UTC) #3

fujiwara

9 years, 11 months ago (2014-07-18 03:59:36 UTC) #4

https://codereview.appspot.com/118830043/diff/1/setup/enginedialog.py
File setup/enginedialog.py (right):

https://codereview.appspot.com/118830043/diff/1/setup/enginedialog.py#newcode52
setup/enginedialog.py:52: 
On 2014/07/18 02:14:30, Peng wrote:
> A suggestion. Using two empty lines between functions. I think it may make
> python code more readable.

Done.

Expand All Messages | Collapse All Messages