Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(312)

Issue 118640043: Protect proxy JSONP responses against "Rosetta Flash" vulnerability. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by kpreid_google
Modified:
11 years, 3 months ago
Reviewers:
felix8a
CC:
caja-discuss-undisclosed_googlegroups.com, MarkM, felix8a, ihab.awad, Jasvir, kpreid2, metaweta, MikeSamuel
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The so-called "Rosetta Flash" vulnerability is that allowing arbitrary yet identifier-like text at the beginning of a JSONP response is sufficient for it to be interpreted as a Flash file executing in that origin. See for more information: http://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/ JSONP responses from the proxy servlet now: * are prefixed with "/**/", which still allows them to execute as JSONP but removes requester control over the first bytes of the response. * have the response header Content-Disposition: attachment. Another recommended mitigation, "X-Content-Type-Options: nosniff", was already present. Bug: <https://code.google.com/p/google-caja/issues/detail?id=1923> @r5697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/com/google/caja/service/ProxyServlet.java View 2 chunks +2 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/test-fetch-proxy.js View 2 chunks +7 lines, -1 line 0 comments Download
M tests/com/google/caja/service/ServiceTestCase.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
kpreid_google
11 years, 5 months ago (2014-08-05 23:42:56 UTC) #1
felix8a
11 years, 5 months ago (2014-08-06 00:15:25 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b