Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 11832043: Preliminary support for CSS3 animations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by MikeSamuel
Modified:
12 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL: 1. Adds support to sanitizeStylesheet for @keyframes rules 2. Adds a CSS property bit for the <global-name> CSS value type 3. Adds entries to the CSS schemas for animation and animation-* properties 4. Adds partial support for <global-nam>s to sanitizeCssProperty 5. Adds tests for well-formed and malformed @keyframes rules Still TODO: thread the ID suffix to sanitizeCssProperty for use in mangling global names. Possibly pass the same virtualization bundle to sanitizeCssProperty as is passed to other sanitizeCss* functions. ---- Submitted @r5510

Patch Set 1 #

Patch Set 2 : Preliminary support for CSS3 animations #

Total comments: 4

Patch Set 3 : Preliminary support for CSS3 animations #

Total comments: 2

Patch Set 4 : Preliminary support for CSS3 animations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -40 lines) Patch
M src/com/google/caja/lang/css/CssPropBit.java View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/com/google/caja/lang/css/css-extensions-defs.json View 1 2 chunks +121 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/css/css-extensions-whitelist.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/sanitizecss.js View 1 2 3 10 chunks +48 lines, -23 lines 0 comments Download
M tests/com/google/caja/plugin/cssparser_test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/sanitizecss_test.js View 1 3 chunks +80 lines, -11 lines 0 comments Download

Messages

Total messages: 9
MikeSamuel
12 years, 7 months ago (2013-07-25 14:08:58 UTC) #1
MikeSamuel
This CL: 1. Adds support to sanitizeStylesheet for @keyframes rules 2. Adds a CSS property ...
12 years, 7 months ago (2013-07-25 14:19:21 UTC) #2
felix8a
lgtm https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js File src/com/google/caja/plugin/sanitizecss.js (right): https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js#newcode24 src/com/google/caja/plugin/sanitizecss.js:24: * \@requires CSS_PROP_BIT_GLOBAL_NAME move before HASH_VALUE for alphabetical ...
12 years, 7 months ago (2013-07-25 18:01:14 UTC) #3
MikeSamuel
This CL: 1. Adds support to sanitizeStylesheet for @keyframes rules 2. Adds a CSS property ...
12 years, 7 months ago (2013-07-25 21:33:46 UTC) #4
MikeSamuel
https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js File src/com/google/caja/plugin/sanitizecss.js (right): https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js#newcode24 src/com/google/caja/plugin/sanitizecss.js:24: * \@requires CSS_PROP_BIT_GLOBAL_NAME On 2013/07/25 18:01:15, felix8a wrote: > ...
12 years, 7 months ago (2013-07-25 21:33:51 UTC) #5
felix8a
lgtm, with fix below https://codereview.appspot.com/11832043/diff/14001/src/com/google/caja/plugin/sanitizecss.js File src/com/google/caja/plugin/sanitizecss.js (right): https://codereview.appspot.com/11832043/diff/14001/src/com/google/caja/plugin/sanitizecss.js#newcode812 src/com/google/caja/plugin/sanitizecss.js:812: && !/__$|[^#0-9A-Za-z:_\-]/.test(animationId)) { need to ...
12 years, 7 months ago (2013-07-25 22:05:27 UTC) #6
MikeSamuel
This CL: 1. Adds support to sanitizeStylesheet for @keyframes rules 2. Adds a CSS property ...
12 years, 7 months ago (2013-07-26 00:03:35 UTC) #7
MikeSamuel
https://codereview.appspot.com/11832043/diff/14001/src/com/google/caja/plugin/sanitizecss.js File src/com/google/caja/plugin/sanitizecss.js (right): https://codereview.appspot.com/11832043/diff/14001/src/com/google/caja/plugin/sanitizecss.js#newcode812 src/com/google/caja/plugin/sanitizecss.js:812: && !/__$|[^#0-9A-Za-z:_\-]/.test(animationId)) { On 2013/07/25 22:05:27, felix8a wrote: > ...
12 years, 7 months ago (2013-07-26 00:04:23 UTC) #8
felix8a
12 years, 7 months ago (2013-07-26 00:14:11 UTC) #9
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b