Issue 118280043: Removed HTML validation errors from +tickets view

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118280043: Removed HTML validation errors from +tickets view (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by sksaurabhkathpalia

Modified:
10 years, 5 months ago

Reviewers:
RogerHaase

Visibility:
Public.

More Reviews

Description

Removed HTML validation errors from +tickets view

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed br tags and added css for the same #

Patch Set 3 : Corrected Indentation of thead #

Patch Set 4 : Removed overlapping border-bottom from tags heading #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -21 lines)			Patch
M	MoinMoin/templates/tickets.html	View	1 2 3	4 chunks	+15 lines, -21 lines	0 comments	Download
M	MoinMoin/themes/basic/static/css/basic.css	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/themes/basic/static/custom-less/basic.less	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/common.css	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/modernized/static/css/common.css	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/themes/modernized/static/css/stylus/main.styl	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

RogerHaase

10 years, 6 months ago (2014-07-24 16:52:55 UTC) #1

https://codereview.appspot.com/118280043/diff/1/MoinMoin/templates/tickets.html
File MoinMoin/templates/tickets.html (right):

https://codereview.appspot.com/118280043/diff/1/MoinMoin/templates/tickets.ht...
MoinMoin/templates/tickets.html:46: <br><br>
use of <br> is similar to putting CSS into HTML

https://codereview.appspot.com/118280043/diff/1/MoinMoin/templates/tickets.ht...
MoinMoin/templates/tickets.html:49: {{ _("%(result_len)d Tickets found.",
result_len=results|length) }}
if you make this <p>nn Tickets found</p>, then you would not need the <br>
above.  If you give it an ID or class, you could style it and control spacing
before or after.  -- or use clear:both if I am wrong about the <p> fixng the
<br>

https://codereview.appspot.com/118280043/diff/1/MoinMoin/templates/tickets.ht...
MoinMoin/templates/tickets.html:51: <thead>
indent thead also for clarity

Expand All Messages | Collapse All Messages