Issue 118080043: Improved code formatting.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118080043: Improved code formatting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by roubert (google)

Modified:
9 years, 10 months ago

Reviewers:
Rouslan Solomakhin

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Improved code formatting. These changes were created using the clang-format tool, and then manually selecting from the changes made by the tool. R=rouslan@chromium.org BUG= Committed: https://code.google.com/p/libaddressinput/source/detail?r=314

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -80 lines)			Patch
M	cpp/src/address_data.cc	View	2 chunks	+11 lines, -13 lines	0 comments	Download
M	cpp/src/address_formatter.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	cpp/src/address_input_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cpp/src/address_ui.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	cpp/src/language.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	cpp/src/lookup_key.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	cpp/src/post_box_matchers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cpp/src/region_data_builder.cc	View	3 chunks	+17 lines, -10 lines	0 comments	Download
M	cpp/src/region_data_constants.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	cpp/src/rule.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	cpp/src/util/json.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	cpp/src/validating_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cpp/src/validation_task.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	cpp/src/validation_task.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	cpp/test/address_input_helper_test.cc	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	cpp/test/address_normalizer_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cpp/test/address_validator_test.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	cpp/test/fake_downloader.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	cpp/test/ondemand_supply_task_test.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	cpp/test/supplier_test.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	cpp/test/validating_storage_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Rouslan Solomakhin

Whitespace changes rubberstamp LGTM. Thank you!

9 years, 10 months ago (2014-07-22 17:42:22 UTC) #2

roubert (google)

9 years, 10 months ago (2014-07-22 18:07:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r314 (presubmit successful).

Expand All Messages | Collapse All Messages