Issue 11795043: CSS parser tests for @keyframes rule

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11795043: CSS parser tests for @keyframes rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by MikeSamuel

Modified:
12 years, 8 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

It looks like the existing CSS parser handles the keyframe syntax alright. This change documents existing behaviour. If we're OK with having the CSS parser call startRuleset and endRuleset to match keyframes, then I can handle @keyframes purely with changes to sanitizecss.js. ---- Submitted @ r5505

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
	M	tests/com/google/caja/plugin/cssparser_test.js	View		1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

felix8a

12 years, 8 months ago (2013-07-24 23:11:15 UTC) #2

lgtm. yeah, I don't think we need to distinguish it from real rulesets, since
it's effectively a ruleset.

Expand All Messages | Collapse All Messages