rerefactor browser test driver

Chrome testing is still failing randomly due to some chromedriver
issue where it hangs forever waiting for something.

This is a refactor that tries to avoid the problem, by reinstating
code to use fresh windows in the same browser instance, but rewritten
a little more cleanly. I've been using this to run Chrome tests
continually on my laptop for a while, and it hasn't failed.

I have low confidence this will actually solve the problem, because
my previous attempt at a fix also ran fine in continual testing on
my laptop. But this was easy to do, and it does have a chance of fixing
the problem, so why not try it.

(My current guess about the failure is that it started happening
because of the forced switch to chromedriver2 because of lack of
support for chromedriver1 in the newer versions of chrome, but I'm
having trouble reproducing a failure and/or capturing info from a
failure, so this is a lot of stumbling in the dark.)

[kpreid2, 2013-07-24 22:45:16]

LGTM

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/B...
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/B...
tests/com/google/caja/plugin/BrowserTestCase.java:90: serverHost =
ThisHostName.value();
Comment on what's going on here — why this condition goes with this value. "If
WEBDRIVER_URL is set, then we're doing remote testing, so..."

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/E...
File tests/com/google/caja/plugin/Echo.java (right):

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/E...
tests/com/google/caja/plugin/Echo.java:21: public class Echo {
a comment talking about why this particular bundle of functions exists would be
nice.

[felix8a, 2013-07-25 00:33:31]

@r5506

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/B...
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/B...
tests/com/google/caja/plugin/BrowserTestCase.java:90: serverHost =
ThisHostName.value();
On 2013/07/24 22:45:16, kpreid2 wrote:
> Comment on what's going on here — why this condition goes with this value. "If
> WEBDRIVER_URL is set, then we're doing remote testing, so..."

Done.

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/E...
File tests/com/google/caja/plugin/Echo.java (right):

https://codereview.appspot.com/11790043/diff/1/tests/com/google/caja/plugin/E...
tests/com/google/caja/plugin/Echo.java:21: public class Echo {
On 2013/07/24 22:45:16, kpreid2 wrote:
> a comment talking about why this particular bundle of functions exists would
be
> nice.

Done.