Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1554)

Issue 117560043: Make CTMalloc use a LRU freelist for its partitions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by chrisha
Modified:
9 years, 9 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make CTMalloc use a LRU freelist for its partitions. This increases memory fragmentation, but also reduces the chance of memory aliasing occurring in a SyzyASan instrumented build. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2225

Patch Set 1 #

Patch Set 2 : Added compile time switch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M third_party/ctmalloc/wtf/PartitionAlloc.h View 1 3 chunks +25 lines, -2 lines 0 comments Download
M third_party/ctmalloc/wtf/PartitionAlloc.cpp View 1 8 chunks +28 lines, -0 lines 0 comments Download
M third_party/ctmalloc/wtf/config.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
chrisha
PTAL
9 years, 9 months ago (2014-08-04 16:31:11 UTC) #1
Sébastien Marchand
lgtm, although I haven't reviewed in details the whole implementation this seems ok. Should we ...
9 years, 9 months ago (2014-08-04 16:47:39 UTC) #2
chrisha
I'll put it behind a compile time conditional so we can compare against the original ...
9 years, 9 months ago (2014-08-05 13:24:26 UTC) #3
chrisha
PTAL?
9 years, 9 months ago (2014-08-05 13:46:00 UTC) #4
Sébastien Marchand
Nice, lgtm.
9 years, 9 months ago (2014-08-05 14:01:33 UTC) #5
chrisha
Thanks, committing!
9 years, 9 months ago (2014-08-05 14:22:52 UTC) #6
chrisha
9 years, 9 months ago (2014-08-05 14:23:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as 2225 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b