Issue 117170043: Create RecursiveLock.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117170043: Create RecursiveLock. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by chrisha

Modified:
9 years, 9 months ago

Reviewers:
Sébastien Marchand

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Create RecursiveLock. This creates a new lock reentrant lock primitive. Base specifically avoids having such a primitive. However, the Windows heap uses such a locking primitive and we need to emulate this with out own heap implementations in SyzyASAN. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2193

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+307 lines, -1 line)			Patch
M	syzygy/common/common.gyp	View	2 chunks	+4 lines, -1 line	0 comments	Download
A	syzygy/common/recursive_lock.h	View	1 chunk	+91 lines, -0 lines	0 comments	Download
A	syzygy/common/recursive_lock.cc	View	1 chunk	+87 lines, -0 lines	0 comments	Download
A	syzygy/common/recursive_lock_unittest.cc	View	1 chunk	+125 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chrisha

9 years, 9 months ago (2014-07-24 21:33:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r2193 (presubmit successful).

Expand All Messages | Collapse All Messages