Issue 117085: specpr issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117085: specpr issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by gorelick

Modified:
11 years, 5 months ago

Reviewers:
Eric

Base URL:
https://oss.mars.asu.edu/svn/davinci/davinci/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Dropped a variable declaration #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
M	dvio.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	dvio_specpr.c	View	1	7 chunks	+19 lines, -6 lines	0 comments	Download
M	ff_load.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Eric

16 years, 11 months ago (2009-09-15 19:43:42 UTC) #1

It's certainly nice to build out the header rather than special case the calls
in *load functions.  However, you're nearly there if you wanted *load functions
to iterate over registered IO handler function pointers, so load would not know
about any of the details.  If that is the intention, isn't it about time to make
the switch?

I ask because gdal is much in my thoughts these days, but it does not really
affect this review. The patch is fine.

Expand All Messages | Collapse All Messages