Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 117051: Ns-3 Net-anim Interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Josh Pelkey
Modified:
10 years, 11 months ago
CC:
ns-3-reviews_googlegroups.com, riley_ece.gatech.edu
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updated after Tom's suggestions #

Total comments: 7

Patch Set 3 : documentation #

Patch Set 4 : merge with ns-3-dev #

Patch Set 5 : Merge net-anim with main #

Patch Set 6 : MinGW ifdefs #

Total comments: 20

Patch Set 7 : Update after Faker's comments #

Total comments: 8

Patch Set 8 : Updates after Tom's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1918 lines, -1513 lines) Patch
M CHANGES.html View 2 chunks +37 lines, -1 line 0 comments Download
M RELEASE_NOTES View 1 chunk +10 lines, -0 lines 0 comments Download
A examples/animation/dumbbell-animation.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A examples/animation/grid-animation.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A examples/animation/star-animation.cc View 1 chunk +134 lines, -0 lines 0 comments Download
A examples/animation/waf View 1 chunk +1 line, -0 lines 0 comments Download
A examples/animation/wscript View 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M examples/csma/csma-star.cc View 6 chunks +26 lines, -45 lines 0 comments Download
M examples/tcp/star.cc View 3 chunks +13 lines, -41 lines 0 comments Download
M examples/wscript View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
R src/contrib/net-anim/animation-interface.h View 1 chunk +0 lines, -120 lines 0 comments Download
R src/contrib/net-anim/animation-interface.cc View 5 1 chunk +0 lines, -202 lines 0 comments Download
R src/contrib/net-anim/node-location.h View 1 chunk +0 lines, -61 lines 0 comments Download
R src/contrib/net-anim/node-location.cc View 1 chunk +0 lines, -56 lines 0 comments Download
R src/contrib/net-anim/point-to-point-dumbbell-helper.h View 1 chunk +0 lines, -77 lines 0 comments Download
R src/contrib/net-anim/point-to-point-dumbbell-helper.cc View 5 1 chunk +0 lines, -249 lines 0 comments Download
R src/contrib/net-anim/point-to-point-grid-helper.h View 1 chunk +0 lines, -57 lines 0 comments Download
R src/contrib/net-anim/point-to-point-grid-helper.cc View 1 chunk +0 lines, -180 lines 0 comments Download
R src/contrib/net-anim/test-dumbbell.cc View 1 chunk +0 lines, -119 lines 0 comments Download
R src/contrib/net-anim/test-grid.cc View 1 chunk +0 lines, -109 lines 0 comments Download
R src/contrib/net-anim/wscript View 5 1 chunk +0 lines, -31 lines 0 comments Download
M src/contrib/wscript View 1 chunk +0 lines, -1 line 0 comments Download
A src/helper/animation-interface.h View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
A src/helper/animation-interface.cc View 1 2 3 4 5 6 7 1 chunk +202 lines, -0 lines 0 comments Download
A src/helper/canvas-location.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/helper/canvas-location.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M src/helper/csma-helper.h View 1 chunk +0 lines, -66 lines 0 comments Download
M src/helper/csma-helper.cc View 1 chunk +0 lines, -21 lines 0 comments Download
A src/helper/csma-star-helper.h View 1 chunk +59 lines, -0 lines 0 comments Download
A src/helper/csma-star-helper.cc View 1 chunk +110 lines, -0 lines 0 comments Download
A src/helper/point-to-point-dumbbell-helper.h View 2 3 4 5 6 7 1 chunk +78 lines, -0 lines 0 comments Download
A src/helper/point-to-point-dumbbell-helper.cc View 2 3 4 5 6 7 1 chunk +267 lines, -0 lines 0 comments Download
A src/helper/point-to-point-grid-helper.h View 2 3 4 5 6 1 chunk +58 lines, -0 lines 0 comments Download
A src/helper/point-to-point-grid-helper.cc View 2 3 4 5 6 7 1 chunk +218 lines, -0 lines 0 comments Download
M src/helper/point-to-point-helper.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/helper/point-to-point-helper.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A src/helper/point-to-point-star-helper.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/helper/point-to-point-star-helper.cc View 1 chunk +159 lines, -0 lines 0 comments Download
M src/helper/wscript View 1 2 3 4 5 6 7 3 chunks +17 lines, -0 lines 0 comments Download
M src/wscript View 5 6 7 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10
Tom Henderson
I would like to see these points considered before merging: 1) align topology helpers with ...
11 years, 4 months ago (2009-09-13 01:59:05 UTC) #1
Josh Pelkey
On 2009/09/13 01:59:05, Tom H. wrote: > I would like to see these points considered ...
11 years, 4 months ago (2009-09-16 18:33:01 UTC) #2
Tom Henderson
http://codereview.appspot.com/117051/diff/51/1028 File src/helper/animation-interface.h (right): http://codereview.appspot.com/117051/diff/51/1028#newcode85 Line 85: bool SetInternalAnimation (); I still suggest to delete ...
11 years, 4 months ago (2009-09-17 05:14:01 UTC) #3
faker.moatamri
http://codereview.appspot.com/117051/diff/8027/8028 File examples/animation/test-dumbbell-animation.cc (right): http://codereview.appspot.com/117051/diff/8027/8028#newcode1 examples/animation/test-dumbbell-animation.cc:1: /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */ If it ...
11 years, 2 months ago (2009-11-09 14:22:13 UTC) #4
Josh Pelkey
Updates after Faker's comments. http://codereview.appspot.com/117051/diff/8027/8028 File examples/animation/test-dumbbell-animation.cc (right): http://codereview.appspot.com/117051/diff/8027/8028#newcode1 examples/animation/test-dumbbell-animation.cc:1: /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; ...
11 years, 2 months ago (2009-11-13 16:59:45 UTC) #5
Tom Henderson
I support moving this out of contrib for ns-3.7. However, I would like to see ...
11 years, 2 months ago (2009-11-16 05:31:43 UTC) #6
Josh Pelkey
Tom, I hope that I have addressed all of your comments which required action before ...
11 years, 2 months ago (2009-11-23 16:01:54 UTC) #7
Tom Henderson
On 2009/11/23 16:01:54, jpelkey wrote: > Tom, > > I hope that I have addressed ...
11 years, 2 months ago (2009-11-24 05:59:34 UTC) #8
Josh Pelkey
On 2009/11/24 05:59:34, Tom Henderson wrote: > On 2009/11/23 16:01:54, jpelkey wrote: > > Tom, ...
11 years, 2 months ago (2009-11-24 16:02:41 UTC) #9
Josh Pelkey
11 years, 1 month ago (2009-12-14 16:31:06 UTC) #10
I have extended the animation section in the manual as well as doxygenized the
helpers.  I started a new codereview for the documentation here:
http://codereview.appspot.com/176077/show

One thing I wasn't sure about was creating a section on NetAnim, since it isn't
a part of ns-3.  I added it anyway, since it was on the wiki.

I am happy to merge this myself.  I just thought I'd put it up here first, since
it is the first time I have contributed to the manual.

--
Josh Pelkey
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b