Issue 11702: Remove caja's dependence on opensocial feature

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11702: Remove caja's dependence on opensocial feature (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 1 month ago by Jasvir

Modified:
16 years, 6 months ago

Reviewers:
Paul Lindner

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Moves caja container setup out of features/opensocial-reference/container.js to features/caja/caja.js. As a result caja gadgets can run cajoled without requiring opensocial. Feature libraries can use caja.tameModule___() to register a function which gets called to tame their api. The pom changes updates the version of caja to one which supports cajoled versions of prototype and jquery.

Patch Set 1 #

Patch Set 2 : Make whitelisters inaccessible by cajoled code #

Total comments: 3

Created: 17 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -51 lines)			Patch
M	features/caja/caja.js	View	1	2 chunks	+53 lines, -0 lines	1 comment	Download
M	features/opensocial-reference/container.js	View		2 chunks	+3 lines, -46 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	javascript/samplecontainer/examples/SocialCajaWorld.xml	View		1 chunk	+1 line, -1 line	1 comment	Download
M	pom.xml	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Paul Lindner

17 years ago (2009-01-22 22:57:59 UTC) #1

looks good other than some minor nits.  However I'm clueless on the actual
implementation and would appreciate community feedback.

http://codereview.appspot.com/11702/diff/201/16
File features/caja/caja.js (right):

http://codereview.appspot.com/11702/diff/201/16#newcode24
Line 24: * @author Jasvir Nagra <jasvir@gmail.com>
don't need this...

http://codereview.appspot.com/11702/diff/201/14
File javascript/samplecontainer/examples/SocialCajaWorld.xml (right):

http://codereview.appspot.com/11702/diff/201/14#newcode4
Line 4: <Require feature="opensocial-0.7"></Require>
why the switch back to 0.7?

http://codereview.appspot.com/11702/diff/201/13
File pom.xml (right):

http://codereview.appspot.com/11702/diff/201/13#newcode966
Line 966: <version>r3164</version>
this is in trunk now...

Expand All Messages | Collapse All Messages