src/pkg/encoding/gob/encode.go - Issue 11699043: code review 11699043: all: be more idiomatic when documenting boolean return ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/encoding/gob/encode.go

Issue 11699043: code review 11699043: all: be more idiomatic when documenting boolean return ... (Closed)

Patch Set: diff -r 677f1dc462af https://code.google.com/p/go/ Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/encoding/gob/encode.go

===================================================================

--- a/src/pkg/encoding/gob/encode.go

+++ b/src/pkg/encoding/gob/encode.go

@@ -474,7 +474,7 @@

enc.freeEncoderState(state)

}

-// isZero returns whether the value is the zero of its type.

+// isZero reports whether the value is the zero of its type.

func isZero(val reflect.Value) bool {

switch val.Kind() {

case reflect.Array: