Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2224)

Issue 116750043: Expose GetLineSeparatorForLanguage in address_formatter.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by Rouslan Solomakhin
Modified:
9 years, 9 months ago
CC:
keghani, davinci_google, dbeaumont
Base URL:
https://libaddressinput.googlecode.com/svn/trunk
Visibility:
Public.

Description

Expose GetLineSeparatorForLanguage in address_formatter.h Chromium uses the separator to collapse multi-line parts of autofill profile into a single line, street address lines, names, emails, and phone numbers. TBR=lararennie@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -40 lines) Patch
M cpp/include/libaddressinput/address_formatter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cpp/src/address_formatter.cc View 2 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 7
Rouslan Solomakhin
FYI.
9 years, 10 months ago (2014-07-12 01:35:41 UTC) #1
Rouslan Solomakhin
Committed patchset #1 manually as r305 (presubmit successful).
9 years, 10 months ago (2014-07-12 01:36:09 UTC) #2
lararennie
I'm a bit concerned about this CL. a) This shouldn't be used to concatenate phone ...
9 years, 9 months ago (2014-07-14 07:40:02 UTC) #3
Rouslan Solomakhin
Filed https://code.google.com/p/chromium/issues/detail?id=393584 to fix the issue in Chrome, after which we can revert this patch.
9 years, 9 months ago (2014-07-14 14:39:24 UTC) #4
Rouslan Solomakhin
Chrome CL @ https://codereview.chromium.org/390083003/
9 years, 9 months ago (2014-07-14 17:14:50 UTC) #5
Rouslan Solomakhin
Reverted in https://code.google.com/p/libaddressinput/source/detail?r=306. Chromium switched from GetLineSeparatorForLanguage to GetStreetAddressLinesAsSingleLine.
9 years, 9 months ago (2014-07-17 03:44:13 UTC) #6
roubert (google)
9 years, 9 months ago (2014-07-17 23:22:10 UTC) #7
Message was sent while issue was closed.
I've now verified the revert.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b