Issue 116420046: Add a PDB header writer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116420046: Add a PDB header writer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by fdoray

Modified:
9 years, 9 months ago

Reviewers:
Sébastien Marchand, chrisha, etienneb

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add a PDB header writer. BUG= R=chrisha@chromium.org, sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2208

Patch Set 2 : Nit from sebmarchand. #

Patch Set 4 : Rebase. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
A +	syzygy/experimental/pdb_writer/pdb_header_stream_writer.h	View	1 2	1 chunk	+11 lines, -10 lines	0 comments	Download
A +	syzygy/experimental/pdb_writer/pdb_header_stream_writer.cc	View		1 chunk	+16 lines, -5 lines	0 comments	Download
M	syzygy/experimental/pdb_writer/pdb_writer.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sébastien Marchand

lgtm. https://codereview.appspot.com/116420046/diff/1/syzygy/experimental/pdb_writer/pdb_header_stream_writer.h File syzygy/experimental/pdb_writer/pdb_header_stream_writer.h (right): https://codereview.appspot.com/116420046/diff/1/syzygy/experimental/pdb_writer/pdb_header_stream_writer.h#newcode22 syzygy/experimental/pdb_writer/pdb_header_stream_writer.h:22: class WritablePdbStream; Add a '// Forward declarations.' comment ...

9 years, 9 months ago (2014-07-30 17:23:30 UTC) #2

fdoray

I addressed the comment from Sebastien. https://codereview.appspot.com/116420046/diff/1/syzygy/experimental/pdb_writer/pdb_header_stream_writer.h File syzygy/experimental/pdb_writer/pdb_header_stream_writer.h (right): https://codereview.appspot.com/116420046/diff/1/syzygy/experimental/pdb_writer/pdb_header_stream_writer.h#newcode22 syzygy/experimental/pdb_writer/pdb_header_stream_writer.h:22: class WritablePdbStream; On ...

9 years, 9 months ago (2014-07-30 17:52:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r2208.

Expand All Messages | Collapse All Messages