Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(153)

Issue 116360043: code review 116360043: crypto/tls: Add new DigestSigner and KeyAlgorithm types... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by jdeprez
Modified:
11 years, 4 months ago
Reviewers:
agl1
CC:
golang-codereviews, jsing
Visibility:
Public.

Description

crypto/tls: Add new DigestSigner and KeyAlgorithm types and fields to Config, implement defaults for each, and use inside doFullHandshake to produce the certificate verify message.

Patch Set 1 #

Patch Set 2 : diff -r fda4c0d14c53 https://code.google.com/p/go #

Patch Set 3 : diff -r fda4c0d14c53 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -15 lines) Patch
M src/pkg/crypto/tls/common.go View 1 chunk +18 lines, -0 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client.go View 3 chunks +48 lines, -15 lines 0 comments Download

Messages

Total messages: 6
jdeprez
Hello agl@golang.org (cc: golang-codereviews@googlegroups.com, jsing@google.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 5 months ago (2014-07-28 02:27:05 UTC) #1
agl1
NACK. I do hope to support this in 1.4, but it's not specific to crypto/tls.
11 years, 5 months ago (2014-07-28 17:44:23 UTC) #2
jdeprez
On 2014/07/28 17:44:23, agl1 wrote: > NACK. > > I do hope to support this ...
11 years, 5 months ago (2014-07-30 01:23:39 UTC) #3
agl1
Please see whether https://codereview.appspot.com/114680043 meets your needs. If so, I'll send it out for review. ...
11 years, 5 months ago (2014-08-01 20:38:41 UTC) #4
agl1
R=close
11 years, 5 months ago (2014-08-01 20:48:33 UTC) #5
jdeprez
11 years, 4 months ago (2014-08-04 00:24:30 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b