Add 'location' config for Azure.

Add 'location' config for Azure.



https://code.launchpad.net/~julian-edwards/juju-core/azure-location-config/+merge/176316

(do not edit description out of merge proposal)

[julian.edwards, 2013-07-23 04:10:54]

Please take a look.

[jtv.canonical, 2013-07-23 04:31:35]

LGTM.  When you find yourself accessing lock-protected properties of the
environment, I would suggest making the whole function operate on a snapshot. 
That way you know that you get a consistent picture, and there's no weirdness
with having two objects.

For internal methods you could even consider making the snapshotting the
caller's job, so the method only deals with one object and does not need to be
aware of locks.  If the interface-exported methods all took snapshots, and
everything from there on down operated on just the snapshots, then there would
be no further need to worry about locking.  (Of course it's perfectly safe to
take a snapshot of a snapshot — something we can't say for Go mutexes).

https://codereview.appspot.com/11621044/diff/1/environs/azure/environ_test.go
File environs/azure/environ_test.go (right):

https://codereview.appspot.com/11621044/diff/1/environs/azure/environ_test.go...
environs/azure/environ_test.go:849: // FIXME: This is a testing antipattern, the
expected data comes from

Thoughtful to add a note about this...  We don't normally use FIXME in Juju
though, only TODO.  Did you mean to fix this before putting it up for review?

[julian.edwards, 2013-07-23 04:58:31]

On 23/07/13 14:31, jtv.canonical@gmail.com wrote:
> environs/azure/environ_test.go:849: // FIXME: This is a testing
> antipattern, the expected data comes from
> 
> Thoughtful to add a note about this...  We don't normally use FIXME in
> Juju though, only TODO.  Did you mean to fix this before putting it up
> for review?
> 
> https://codereview.appspot.com/11621044/

I meant it as a FIXME but if juju requires TODO then I'll change it.

And no I didn't intend to fix it here.

[thumper, 2013-07-23 05:06:40]

On 2013/07/23 04:58:31, julian.edwards wrote:
> On 23/07/13 14:31, mailto:jtv.canonical@gmail.com wrote:
> > environs/azure/environ_test.go:849: // FIXME: This is a testing
> > antipattern, the expected data comes from
> > 
> > Thoughtful to add a note about this...  We don't normally use FIXME in
> > Juju though, only TODO.  Did you mean to fix this before putting it up
> > for review?
> > 
> > https://codereview.appspot.com/11621044/
> 
> I meant it as a FIXME but if juju requires TODO then I'll change it.
> 
> And no I didn't intend to fix it here.

TODO(bigjools):

[thumper, 2013-07-23 05:07:13]

LGTM