Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(397)

Issue 1162041: [FreeType] Always use MONO hinting when hinting in monochrome.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by agl
Modified:
14 years, 6 months ago
Reviewers:
evan
Visibility:
Public.

Description

[FreeType] Always use MONO hinting when hinting in monochrome. This matches the behaviour of Cairo. It appears to be an undocumented trick of font rendering on Linux that, in monochrome, all the hinting modes expect no-hinting are mapped to FreeType's MONO hinting. http://code.google.com/p/chromium/issues/detail?id=43252

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +27 lines, -20 lines 1 comment Download

Messages

Total messages: 4
agl
14 years, 6 months ago (2010-05-07 19:24:54 UTC) #1
evan
Do we have any way to test this? Will this break Android? LGTM in any ...
14 years, 6 months ago (2010-05-07 23:50:39 UTC) #2
evan
http://codereview.appspot.com/1162041/diff/1/2 File src/ports/SkFontHost_FreeType.cpp (right): http://codereview.appspot.com/1162041/diff/1/2#newcode363 src/ports/SkFontHost_FreeType.cpp:363: loadFlags = FT_LOAD_NO_HINTING; BTW, from that cairo snippet you ...
14 years, 6 months ago (2010-05-09 15:59:20 UTC) #3
agl
14 years, 6 months ago (2010-05-10 14:18:10 UTC) #4
On Fri, May 7, 2010 at 7:50 PM,  <evan@chromium.org> wrote:
> Do we have any way to test this?

The day of work required to write a test for this isn't worthwhile,
although it makes me sad that writing tests is so hard these days.

> Will this break Android?

I believe not. I don't think they use mono text and, even if they do
in some cases, I'm sure they hint it fully.


AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b