Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1011)

Issue 116200043: A poor man's release-time assert for failing to open the test data file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by Rouslan Solomakhin
Modified:
9 years, 9 months ago
Reviewers:
roubert (google)
CC:
lararennie, dbeaumont, keghani, davinci
Base URL:
https://libaddressinput.googlecode.com/svn/trunk
Visibility:
Public.

Description

A poor man's release-time assert for failing to open the test data file. This patch prevents running unit tests from an incorrect directory in release mode. Release mode builds ignore assert(file.is_open()) for the test data file, which causes many hard-to-diagnose crashes due to the rest of the code relying on that file being open. See http://crbug.com/395169 and http://crbug.com/396203 for examples. R=roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cpp/test/fake_downloader.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3
Rouslan Solomakhin
Fredrik: PTAL.
9 years, 9 months ago (2014-07-23 18:35:22 UTC) #1
roubert (google)
LGTM This is a good example of why I don't think that it generally is ...
9 years, 9 months ago (2014-07-23 19:16:41 UTC) #2
Rouslan Solomakhin
9 years, 9 months ago (2014-07-23 19:52:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r316 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b