code review 116060043: cmd/gc: mark auxiliary symbols as containing no pointers

src/cmd/5g/gsubr.c

 // Derived from Inferno utils/5c/txt.c
 // http://code.google.com/p/inferno-os/source/browse/utils/5c/txt.c
 //
 //      Copyright © 1994-1999 Lucent Technologies Inc.  All rights reserved.
 //      Portions Copyright © 1995-1997 C H Forsyth (forsyth@terzarima.net)
 //      Portions Copyright © 1997-1999 Vita Nuova Limited
 //      Portions Copyright © 2000-2007 Vita Nuova Holdings Limited (www.vitanuova.com)
 //      Portions Copyright © 2004,2006 Bruce Ellis
 //      Portions Copyright © 2005-2007 C H Forsyth (forsyth@terzarima.net)
 //      Revisions Copyright © 2000-2007 Lucent Technologies Inc. and others
@@ skipping 198 matching lines @@
 gargsize(int32 size)
 {
         Node n1, n2;
 ········
         nodconst(&n1, types[TINT32], PCDATA_ArgSize);
         nodconst(&n2, types[TINT32], size);
         gins(APCDATA, &n1, &n2);
 }
 
 void
-ggloblsym(Sym *s, int32 width, int dupok, int rodata)
+ggloblsym(Sym *s, int32 width, int dupok, int rodata, int hasptr)
 {
         Prog *p;
 
         p = gins(AGLOBL, N, N);
         p->from.type = D_OREG;
         p->from.name = D_EXTERN;
         p->from.sym = linksym(s);
         p->to.type = D_CONST;
         p->to.name = D_NONE;
         p->to.offset = width;
         if(dupok)
                 p->reg |= DUPOK;
         if(rodata)
                 p->reg |= RODATA;
+        if(!hasptr)

[rsc, 2014/07/22 03:42:17]

now that the flags have names, just make ggloblsym take the flag list.

[dvyukov, 2014/07/22 07:43:48]

do you mean to take "int flags" and callers will pass DUPOK|NOPTR?

+                p->reg |= NOPTR;
 }
 
 void
 gtrack(Sym *s)
 {
         Prog *p;
 ········
         p = gins(AUSEFIELD, N, N);
         p->from.type = D_OREG;
         p->from.name = D_EXTERN;
@@ skipping 1843 matching lines @@
         naddr(&n2, a, 1);
         goto yes;
 
 yes:
         return 1;
 
 no:
         sudoclean();
         return 0;
 }