Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 116056: Fix Proxy handler to configure makeRequest correctly

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 5 months ago by Arne Roomann-Kurrik
Modified:
16 years, 5 months ago
Reviewers:
chabotc1
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/
Visibility:
Public.

Description

This patch fixes the error message you saw when requesting proxied assets: 1.) Removes your patch to return if the parameter is empty (we could actually leave that in, it would mean that explicitly configured parameters with no value would be ignored for requests expecting a structured type, though) 2.) Corrects the error message when expecting a structured type. What I don't like about this right now is that it doesn't mention the parameter name, but fixing that would be pretty ugly. 3.) Allows for creating a ProxyBase with an instance of a makeRequest object (needed for a forthcoming unit test patch). 4.) The main fix - change the defaults in ProxyBase to null instead of an empty string, when creating a MakeRequestOptions class from the request.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/gadgets/MakeRequestOptions.php View 1 chunk +1 line, -4 lines 0 comments Download
M src/gadgets/ProxyBase.php View 2 chunks +8 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b