Issue 116041: Some simple changes that double the speed of HTML rendering.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116041: Some simple changes that double the speed of HTML rendering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by MikeSamuel

Modified:
16 years, 9 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Reworks Nodes.render. Still need to profile and speed up the HTML escaping. Submitted @3718

Patch Set 2 : Some simple changes that double the speed of HTML rendering. #

Patch Set 3 : Some simple changes that double the speed of HTML rendering. #

Total comments: 2

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -139 lines)			Patch
M	src/com/google/caja/lexer/escaping/Escaper.java	View		4 chunks	+42 lines, -14 lines	0 comments	Download
M	src/com/google/caja/parser/html/Nodes.java	View	1	2 chunks	+104 lines, -89 lines	0 comments	Download
M	src/com/google/caja/plugin/templates/Localizer.java	View		2 chunks	+52 lines, -24 lines	0 comments	Download
M	src/com/google/caja/util/Strings.java	View	2	3 chunks	+20 lines, -12 lines	0 comments	Download
M	tests/com/google/caja/util/StringsTest.java	View		5 chunks	+41 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

metaweta

LGTM http://codereview.appspot.com/116041/diff/1004/1005 File tests/com/google/caja/util/StringsTest.java (right): http://codereview.appspot.com/116041/diff/1004/1005#newcode89 Line 89: public final void testToLowerCase() { Do we ...

16 years, 9 months ago (2009-09-09 19:02:59 UTC) #2

MikeSamuel

16 years, 9 months ago (2009-09-09 19:06:07 UTC) #3

http://codereview.appspot.com/116041/diff/1004/1005
File tests/com/google/caja/util/StringsTest.java (right):

http://codereview.appspot.com/116041/diff/1004/1005#newcode89
Line 89: public final void testToLowerCase() {
On 2009/09/09 19:03:00, metaweta wrote:
> Do we need anything special for Turkish?

Our ant tests already run in the Turkish locale.
From build.xml
    <junit printsummary="yes" fork="yes" maxmemory="512m"
     errorProperty="runtests.error" failureProperty="runtests.failure">
      ...
      <sysproperty key="user.language" value="tr"/>
      <sysproperty key="user.region" value="TR"/>

Expand All Messages | Collapse All Messages