Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 116041: Some simple changes that double the speed of HTML rendering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 9 months ago by MikeSamuel
Modified:
16 years, 9 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Reworks Nodes.render. Still need to profile and speed up the HTML escaping. Submitted @3718

Patch Set 1 #

Patch Set 2 : Some simple changes that double the speed of HTML rendering. #

Patch Set 3 : Some simple changes that double the speed of HTML rendering. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -139 lines) Patch
M src/com/google/caja/lexer/escaping/Escaper.java View 4 chunks +42 lines, -14 lines 0 comments Download
M src/com/google/caja/parser/html/Nodes.java View 1 2 chunks +104 lines, -89 lines 0 comments Download
M src/com/google/caja/plugin/templates/Localizer.java View 2 chunks +52 lines, -24 lines 0 comments Download
M src/com/google/caja/util/Strings.java View 2 3 chunks +20 lines, -12 lines 0 comments Download
M tests/com/google/caja/util/StringsTest.java View 5 chunks +41 lines, -0 lines 2 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 9 months ago (2009-09-03 21:56:32 UTC) #1
metaweta
LGTM http://codereview.appspot.com/116041/diff/1004/1005 File tests/com/google/caja/util/StringsTest.java (right): http://codereview.appspot.com/116041/diff/1004/1005#newcode89 Line 89: public final void testToLowerCase() { Do we ...
16 years, 9 months ago (2009-09-09 19:02:59 UTC) #2
MikeSamuel
16 years, 9 months ago (2009-09-09 19:06:07 UTC) #3
http://codereview.appspot.com/116041/diff/1004/1005
File tests/com/google/caja/util/StringsTest.java (right):

http://codereview.appspot.com/116041/diff/1004/1005#newcode89
Line 89: public final void testToLowerCase() {
On 2009/09/09 19:03:00, metaweta wrote:
> Do we need anything special for Turkish?

Our ant tests already run in the Turkish locale.
From build.xml
    <junit printsummary="yes" fork="yes" maxmemory="512m"
     errorProperty="runtests.error" failureProperty="runtests.failure">
      ...
      <sysproperty key="user.language" value="tr"/>
      <sysproperty key="user.region" value="TR"/>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b