Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 11587043: api samples: Update samples to 1.16.0-rc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by ngmiceli
Modified:
11 years, 9 months ago
Reviewers:
peleyal, yanivi
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

api samples: Update samples to 1.16.0-rc The updated jars for the Android samples have not been included in this codereview, as they are too large. The following samples have been tested: calendar-cmdline-sample plus-appengine-sample calendar-android-sample

Patch Set 1 #

Total comments: 28

Patch Set 2 : Minor comment fixes #

Patch Set 3 : Make DataStoreFactory global pt. 1 #

Total comments: 2

Patch Set 4 : Make DataStoreFactory global #

Patch Set 5 : Update GAE samples to official plugin #

Total comments: 10

Patch Set 6 : Javadoc & update urlshortener-robots-appengine-sample to official plugin #

Patch Set 7 : Removed -SNAPSHOT #

Patch Set 8 : Final check #

Patch Set 9 : Javadoc fix #

Patch Set 10 : Revision update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1125 lines, -898 lines) Patch
M adexchangebuyer-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M adexchangebuyer-cmdline-sample/src/main/java/com/google/api/services/samples/adexchangebuyer/cmdline/AdExchangeBuyerSample.java View 1 2 8 chunks +23 lines, -17 lines 0 comments Download
M adsense-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M adsense-cmdline-sample/src/main/java/com/google/api/services/samples/adsense/cmdline/AdSenseSample.java View 1 2 3 6 chunks +70 lines, -63 lines 0 comments Download
M adsensehost-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java View 1 2 3 7 chunks +64 lines, -59 lines 0 comments Download
M analytics-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/CoreReportingApiReferenceSample.java View 1 2 10 chunks +41 lines, -36 lines 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/HelloAnalyticsApiSample.java View 1 2 3 4 5 6 7 8 12 chunks +27 lines, -22 lines 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/ManagementApiReferenceSample.java View 1 2 3 4 5 6 7 8 15 chunks +54 lines, -52 lines 0 comments Download
M analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/McfReportingApiReferenceSample.java View 1 2 3 4 5 6 7 8 19 chunks +36 lines, -31 lines 0 comments Download
M bigquery-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +1 line, -1 line 0 comments Download
M bigquery-appengine-sample/instructions.html View 1 2 3 4 2 chunks +29 lines, -4 lines 0 comments Download
M bigquery-appengine-sample/pom.xml View 1 2 3 4 5 6 7 4 chunks +20 lines, -28 lines 0 comments Download
M bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/ServiceUtils.java View 1 2 3 chunks +14 lines, -8 lines 0 comments Download
M books-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M calendar-android-sample/.classpath View 1 2 3 8 1 chunk +1 line, -0 lines 0 comments Download
M calendar-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +1 line, -1 line 0 comments Download
M calendar-appengine-sample/instructions.html View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M calendar-appengine-sample/pom.xml View 1 2 3 4 5 6 7 4 chunks +19 lines, -20 lines 0 comments Download
M calendar-appengine-sample/src/main/java/com/google/api/services/samples/calendar/appengine/server/Utils.java View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M calendar-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M calendar-cmdline-sample/src/main/java/com/google/api/services/samples/calendar/cmdline/CalendarSample.java View 1 2 3 6 chunks +37 lines, -30 lines 0 comments Download
M compute-engine-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M compute-engine-cmdline-sample/src/main/java/com/google/api/services/samples/computeengine/cmdline/ComputeEngineSample.java View 1 2 3 6 chunks +38 lines, -36 lines 0 comments Download
M dfareporting-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M dfareporting-cmdline-sample/src/main/java/com/google/api/services/samples/dfareporting/cmdline/DfaReportingSample.java View 1 2 3 5 chunks +53 lines, -48 lines 0 comments Download
M discovery-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M discovery-cmdline-sample/src/main/java/com/google/api/services/samples/discovery/cmdline/DiscoverySample.java View 1 2 8 chunks +19 lines, -12 lines 0 comments Download
M drive-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M drive-cmdline-sample/src/main/java/com/google/api/services/samples/drive/cmdline/DriveSample.java View 1 2 3 5 chunks +36 lines, -28 lines 0 comments Download
M fusiontables-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java View 1 2 3 6 chunks +36 lines, -30 lines 0 comments Download
M latitude-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M latitude-cmdline-sample/src/main/java/com/google/api/services/samples/latitude/cmdline/LatitudeSample.java View 1 2 3 7 chunks +25 lines, -19 lines 0 comments Download
M oauth2-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M oauth2-cmdline-sample/src/main/java/com/google/api/services/samples/oauth2/cmdline/OAuth2Sample.java View 1 2 3 6 chunks +32 lines, -26 lines 0 comments Download
M picasa-cmdline-sample/pom.xml View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaSample.java View 1 2 3 6 chunks +18 lines, -8 lines 0 comments Download
M plus-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +1 line, -1 line 0 comments Download
M plus-appengine-sample/pom.xml View 1 2 3 4 5 6 7 8 9 4 chunks +5 lines, -6 lines 0 comments Download
M plus-appengine-sample/src/main/java/com/google/api/services/samples/plus/Utils.java View 1 2 3 3 chunks +11 lines, -3 lines 0 comments Download
M plus-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M plus-cmdline-sample/src/main/java/com/google/api/services/samples/plus/cmdline/PlusSample.java View 1 2 3 5 chunks +33 lines, -26 lines 0 comments Download
M plus-serviceaccount-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M prediction-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M prediction-cmdline-sample/src/main/java/com/google/api/services/samples/prediction/cmdline/PredictionSample.java View 1 2 3 7 chunks +24 lines, -18 lines 0 comments Download
M shared/gdata/shared-sample-gdata/pom.xml View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M siteVerification-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M siteVerification-cmdline-sample/src/main/java/com/google/api/services/samples/verification/cmdline/VerificationSample.java View 1 2 3 7 chunks +24 lines, -19 lines 0 comments Download
M storage-cmdline-sample/pom.xml View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M storage-cmdline-sample/src/main/java/com/google/api/services/samples/storage/cmdline/StorageSample.java View 1 2 3 21 chunks +90 lines, -92 lines 0 comments Download
M storage-serviceaccount-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +1 line, -1 line 0 comments Download
M storage-serviceaccount-appengine-sample/instructions.html View 1 2 3 4 1 chunk +30 lines, -3 lines 0 comments Download
M storage-serviceaccount-appengine-sample/pom.xml View 1 2 3 4 5 6 5 chunks +18 lines, -29 lines 0 comments Download
M storage-serviceaccount-cmdline-sample/pom.xml View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M taskqueue-cmdline-sample/pom.xml View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M taskqueue-cmdline-sample/src/main/java/com/google/api/services/samples/taskqueue/cmdline/TaskQueueSample.java View 1 2 3 4 5 12 chunks +40 lines, -28 lines 0 comments Download
M tasks-android-sample/.classpath View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M urlshortener-robots-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +1 line, -1 line 0 comments Download
M urlshortener-robots-appengine-sample/instructions.html View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
M urlshortener-robots-appengine-sample/pom.xml View 1 2 3 4 5 6 5 chunks +17 lines, -23 lines 0 comments Download
M urlshortener-robots-appengine-sample/src/main/java/com/google/api/client/sample/urlshortener/appengine/robots/UrlShortenerSample.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
ngmiceli
11 years, 10 months ago (2013-07-19 16:56:43 UTC) #1
peleyal
https://codereview.appspot.com/11587043/diff/1/adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java File adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java (right): https://codereview.appspot.com/11587043/diff/1/adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java#newcode108 adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java:108: new FileDataStoreFactory(DATA_STORE_DIR)).build(); I think we should store that DataStoreFactory ...
11 years, 10 months ago (2013-07-19 19:45:51 UTC) #2
ngmiceli
Didn't finish the DataStoreFactory refactoring by EOD. Will continue on Monday. https://codereview.appspot.com/11587043/diff/1/analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/CoreReportingApiReferenceSample.java File analytics-cmdline-sample/src/main/java/com/google/api/services/samples/analytics/cmdline/CoreReportingApiReferenceSample.java (right): ...
11 years, 10 months ago (2013-07-19 21:57:33 UTC) #3
yanivi
https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/pom.xml File bigquery-appengine-sample/pom.xml (right): https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/pom.xml#newcode57 bigquery-appengine-sample/pom.xml:57: <artifactId>maven-gae-plugin</artifactId> we should take the time to update all ...
11 years, 10 months ago (2013-07-22 12:52:25 UTC) #4
ngmiceli
On 2013/07/22 12:52:25, yanivi wrote: > https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/pom.xml > File bigquery-appengine-sample/pom.xml (right): > > https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/pom.xml#newcode57 > ...
11 years, 10 months ago (2013-07-22 15:58:30 UTC) #5
ngmiceli
PTAL https://codereview.appspot.com/11587043/diff/1/adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java File adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java (right): https://codereview.appspot.com/11587043/diff/1/adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java#newcode108 adsensehost-cmdline-sample/src/main/java/com/google/api/services/samples/adsensehost/cmdline/AdSenseHostSample.java:108: new FileDataStoreFactory(DATA_STORE_DIR)).build(); On 2013/07/19 19:45:51, peleyal wrote: > ...
11 years, 10 months ago (2013-07-22 15:59:57 UTC) #6
peleyal
Like Yaniv likes to say: almost there :) Let's finish with that today! https://codereview.appspot.com/11587043/diff/1/bigquery-appengine-sample/pom.xml File ...
11 years, 10 months ago (2013-07-22 18:56:55 UTC) #7
ngmiceli
https://codereview.appspot.com/11587043/diff/82001/plus-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs File plus-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs (right): https://codereview.appspot.com/11587043/diff/82001/plus-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs#newcode2 plus-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs:2: filesCopiedToWebInfLib=appengine-api-1.0-sdk-1.8.2.jar|appengine-api-labs.jar|appengine-endpoints.jar|appengine-jsr107cache-1.8.2.jar|datanucleus-appengine-1.0.10.final.jar|datanucleus-core-1.1.5.jar|datanucleus-jpa-1.1.5.jar|geronimo-jpa_3.0_spec-1.1.1.jar|geronimo-jta_1.1_spec-1.1.1.jar|jdo2-api-2.3-eb.jar|jsr107cache-1.1.jar On 2013/07/22 18:56:56, peleyal wrote: > Do you ...
11 years, 10 months ago (2013-07-22 19:31:05 UTC) #8
peleyal
LGTM, just please correct my two silly comments https://codereview.appspot.com/11587043/diff/82001/bigquery-appengine-sample/pom.xml File bigquery-appengine-sample/pom.xml (right): https://codereview.appspot.com/11587043/diff/82001/bigquery-appengine-sample/pom.xml#newcode46 bigquery-appengine-sample/pom.xml:46: please ...
11 years, 10 months ago (2013-07-22 19:39:59 UTC) #9
ngmiceli
https://codereview.appspot.com/11587043/diff/1/bigquery-appengine-sample/pom.xml File bigquery-appengine-sample/pom.xml (right): https://codereview.appspot.com/11587043/diff/1/bigquery-appengine-sample/pom.xml#newcode17 bigquery-appengine-sample/pom.xml:17: <pluginRepository> On 2013/07/22 18:56:56, peleyal wrote: > why did ...
11 years, 10 months ago (2013-07-22 19:45:54 UTC) #10
yanivi
11 years, 10 months ago (2013-07-22 20:49:46 UTC) #11
On 2013/07/22 15:58:30, ngmiceli wrote:
> On 2013/07/22 12:52:25, yanivi wrote:
> >
>
https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/...
> > File bigquery-appengine-sample/pom.xml (right):
> > 
> >
>
https://codereview.appspot.com/11587043/diff/12006/bigquery-appengine-sample/...
> > bigquery-appengine-sample/pom.xml:57:
> <artifactId>maven-gae-plugin</artifactId>
> > we should take the time to update all of the appengine samples to
> > appengine-maven-plugin (version 1.8.2) and update instructions on how to
> deploy
> > to appspot
> > 
> > see plus-appengine-sample
> 
> Done.

Awesome, thanks Nick!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b