state/api/(deployer,upgrader): consistent naming

state/api/(deployer,upgrader): consistent naming

We already have machiner.State and machineagent.State;
this brings the deployer and upgrader packages into line.
The reasoning behind the name is that, even though we are
talking through the API, we are talking to the juju state
nevertheless - an indirection should not need a rename
in the client code.

Note: there are no logic changes in this branch.

https://code.launchpad.net/~rogpeppe/juju-core/341-rename-worker-types/+merge/175891

(do not edit description out of merge proposal)

[rog, 2013-07-19 16:43:09]

Please take a look.

[dimitern, 2013-07-19 16:47:42]

LGTM with a couple of comments.

https://codereview.appspot.com/11586043/diff/3001/state/api/deployer/deployer.go
File state/api/deployer/deployer.go (right):

https://codereview.appspot.com/11586043/diff/3001/state/api/deployer/deployer...
state/api/deployer/deployer.go:56: // Machine provides access to methods of a
state.Machine through the facade.
// Machine provides the machine with the given tag. ?

https://codereview.appspot.com/11586043/diff/3001/state/api/state.go
File state/api/state.go (right):

https://codereview.appspot.com/11586043/diff/3001/state/api/state.go#newcode44
state/api/state.go:44: return upgrader.New(st), nil
If it's about consistency, then upgrader.NewState.

[rog, 2013-07-19 17:08:32]

Please take a look.

https://codereview.appspot.com/11586043/diff/3001/state/api/deployer/deployer.go
File state/api/deployer/deployer.go (right):

https://codereview.appspot.com/11586043/diff/3001/state/api/deployer/deployer...
state/api/deployer/deployer.go:56: // Machine provides access to methods of a
state.Machine through the facade.
On 2013/07/19 16:47:42, dimitern wrote:
> // Machine provides the machine with the given tag. ?

done, slightly differently.

https://codereview.appspot.com/11586043/diff/3001/state/api/state.go
File state/api/state.go (right):

https://codereview.appspot.com/11586043/diff/3001/state/api/state.go#newcode44
state/api/state.go:44: return upgrader.New(st), nil
On 2013/07/19 16:47:42, dimitern wrote:
> If it's about consistency, then upgrader.NewState.

Done.

[rog, 2013-07-19 17:10:34]

Please take a look.

[mue, 2013-07-23 09:02:58]

LGTM