|
|
Refactor the Downloader interface into the Source interface.
Most implementations of this interface don't actually download anything,
so it's more logical to name the interface something else and define it
in terms of lookup keys ("data/CH") instead of URLs, and let those
implementations that do perform network access handle the mapping from
keys to URLs instead.
This simplifies most implementations of this interface and also the
Retriever, which now no longer needs to keep track of the base URL
(which in most cases was bogus anyway).
This change will break all current users of the libaddressinput API.
Ad infinitum et ultra!
TBR=rouslan@chromium.org
BUG=
Committed: https://code.google.com/p/libaddressinput/source/detail?r=326
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+260 lines, -1188 lines) |
Patch |
 |
M |
cpp/include/libaddressinput/address_validator.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
D |
cpp/include/libaddressinput/downloader.h
|
View
|
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
|
M |
cpp/include/libaddressinput/ondemand_supplier.h
|
View
|
|
2 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
|
M |
cpp/include/libaddressinput/preload_supplier.h
|
View
|
|
3 chunks |
+5 lines, -12 lines |
0 comments
|
Download
|
|
A + |
cpp/include/libaddressinput/source.h
|
View
|
|
2 chunks |
+17 lines, -16 lines |
0 comments
|
Download
|
|
M |
cpp/include/libaddressinput/storage.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
cpp/libaddressinput.gypi
|
View
|
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
D |
cpp/src/lookup_key_util.h
|
View
|
|
1 chunk |
+0 lines, -59 lines |
0 comments
|
Download
|
|
D |
cpp/src/lookup_key_util.cc
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
|
M |
cpp/src/ondemand_supplier.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
cpp/src/preload_supplier.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
cpp/src/retriever.h
|
View
|
|
2 chunks |
+12 lines, -18 lines |
0 comments
|
Download
|
|
M |
cpp/src/retriever.cc
|
View
|
|
6 chunks |
+14 lines, -21 lines |
0 comments
|
Download
|
|
M |
cpp/test/address_input_helper_test.cc
|
View
|
|
6 chunks |
+11 lines, -15 lines |
0 comments
|
Download
|
|
M |
cpp/test/address_normalizer_test.cc
|
View
|
|
1 chunk |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
cpp/test/address_validator_test.cc
|
View
|
|
3 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
D |
cpp/test/fake_downloader.h
|
View
|
|
1 chunk |
+0 lines, -75 lines |
0 comments
|
Download
|
|
D |
cpp/test/fake_downloader.cc
|
View
|
|
1 chunk |
+0 lines, -192 lines |
0 comments
|
Download
|
|
D |
cpp/test/fake_downloader_test.cc
|
View
|
|
1 chunk |
+0 lines, -207 lines |
0 comments
|
Download
|
|
M |
cpp/test/fake_storage.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
cpp/test/fake_storage_test.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
D |
cpp/test/lookup_key_util_test.cc
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
cpp/test/mock_downloader.h
|
View
|
|
1 chunk |
+0 lines, -79 lines |
0 comments
|
Download
|
|
D |
cpp/test/mock_downloader.cc
|
View
|
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
|
A + |
cpp/test/mock_source.h
|
View
|
|
2 chunks |
+21 lines, -26 lines |
0 comments
|
Download
|
|
A + |
cpp/test/mock_source.cc
|
View
|
|
2 chunks |
+5 lines, -19 lines |
0 comments
|
Download
|
|
M |
cpp/test/ondemand_supply_task_test.cc
|
View
|
|
10 chunks |
+17 lines, -19 lines |
0 comments
|
Download
|
|
M |
cpp/test/preload_supplier_test.cc
|
View
|
|
1 chunk |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
cpp/test/region_data_builder_test.cc
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
cpp/test/retriever_test.cc
|
View
|
|
6 chunks |
+14 lines, -20 lines |
0 comments
|
Download
|
|
M |
cpp/test/rule_retriever_test.cc
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
cpp/test/supplier_test.cc
|
View
|
|
5 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
A + |
cpp/test/testdata_source.h
|
View
|
|
1 chunk |
+25 lines, -29 lines |
0 comments
|
Download
|
|
A + |
cpp/test/testdata_source.cc
|
View
|
|
8 chunks |
+29 lines, -47 lines |
0 comments
|
Download
|
|
A + |
cpp/test/testdata_source_test.cc
|
View
|
|
4 chunks |
+48 lines, -63 lines |
0 comments
|
Download
|
Total messages: 3
|
