Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 115370043: Expose the PDB hash function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by fdoray
Modified:
11 years, 9 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Expose the PDB hash function. The hash function used in the named streams table of a PDB file is also used to generate the "public symbols" stream. This CL moves the hash function out of the anonymous namespace of pdb_util.cc so that it can be used to generate a "public symbols" stream. BUG= R=chrisha@chromium.org, etienneb@chromium.org, sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2204

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit from sebmarchand. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M syzygy/pdb/pdb_util.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M syzygy/pdb/pdb_util.cc View 1 2 3 chunks +28 lines, -31 lines 0 comments Download
M syzygy/pdb/pdb_util_unittest.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
fdoray
Could you review this CL? Thanks.
11 years, 9 months ago (2014-07-29 15:21:30 UTC) #1
Sébastien Marchand
lgtm with a nit ! https://codereview.appspot.com/115370043/diff/1/syzygy/pdb/pdb_util.h File syzygy/pdb/pdb_util.h (right): https://codereview.appspot.com/115370043/diff/1/syzygy/pdb/pdb_util.h#newcode81 syzygy/pdb/pdb_util.h:81: // srcsrv tools. Please ...
11 years, 9 months ago (2014-07-29 15:24:32 UTC) #2
etienneb
lgtm.
11 years, 9 months ago (2014-07-29 16:56:30 UTC) #3
chrisha
lgtm % seb's nit
11 years, 9 months ago (2014-07-29 16:57:07 UTC) #4
fdoray
https://codereview.appspot.com/115370043/diff/1/syzygy/pdb/pdb_util.h File syzygy/pdb/pdb_util.h (right): https://codereview.appspot.com/115370043/diff/1/syzygy/pdb/pdb_util.h#newcode81 syzygy/pdb/pdb_util.h:81: // srcsrv tools. On 2014/07/29 15:24:32, Sébastien Marchand wrote: ...
11 years, 9 months ago (2014-07-30 14:10:51 UTC) #5
fdoray
11 years, 9 months ago (2014-07-30 19:43:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r2204.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b