Issue 115150043: Add assert(this != &rule) in Rule::CopyFrom().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115150043: Add assert(this != &rule) in Rule::CopyFrom(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by roubert (google)

Modified:
9 years, 9 months ago

Reviewers:
Rouslan Solomakhin

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add assert(this != &rule) in Rule::CopyFrom(). It does not make any sense to copy a Rule object onto itself. R=rouslan@chromium.org BUG= Committed: https://code.google.com/p/libaddressinput/source/detail?r=313

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	cpp/src/rule.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

9 years, 9 months ago (2014-07-21 19:37:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r313 (presubmit successful).

Expand All Messages | Collapse All Messages