Issue 115120043: Do not go past the end of an empty vector in CombineLinesForLanguage.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 115120043: Do not go past the end of an empty vector in CombineLinesForLanguage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Rouslan Solomakhin

Modified:
9 years, 9 months ago

Reviewers:
lararennie

CC:
roubert (google), keghani, davinci_google, dbeaumont

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Do not go past the end of an empty vector in CombineLinesForLanguage. TBR=lararennie@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=310

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	cpp/src/address_formatter.cc	View		1 chunk	+10 lines, -9 lines	0 comments	Download
	M	cpp/test/address_formatter_test.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Rouslan Solomakhin

Committed patchset #1 manually as r310 (presubmit successful).

9 years, 9 months ago (2014-07-19 19:52:11 UTC) #2

Message was sent while issue was closed.

LGTM :)

Expand All Messages | Collapse All Messages