Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 115089: remove unused 'target' field from Job (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by felix8a
Modified:
16 years, 6 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

the Job class has a 'target' field that isn't used, and probably doesn't work correctly if it is used. I was trying to write another pipeline stage, and got confused by Job.target, and couldn't convince myself that Job.target was going to behave correctly, then found out that it isn't used by any reachable code. this change deletes all the references to Job.target.

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused 'target' field from Job #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M src/com/google/caja/plugin/Job.java View 2 chunks +1 line, -16 lines 0 comments Download
M src/com/google/caja/plugin/stages/ConsolidateCodeStage.java View 1 2 chunks +10 lines, -17 lines 0 comments Download
M tests/com/google/caja/service/CajolingServiceTest.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
felix8a
16 years, 6 months ago (2009-09-10 21:49:39 UTC) #1
MikeSamuel
http://codereview.appspot.com/115089/diff/1/2 File src/com/google/caja/plugin/stages/ConsolidateCodeStage.java (right): http://codereview.appspot.com/115089/diff/1/2#newcode20 Line 20: import com.google.caja.parser.ParseTreeNode; Is this still used?
16 years, 6 months ago (2009-09-10 21:55:48 UTC) #2
felix8a
On 2009/09/10 21:55:48, MikeSamuel wrote: > http://codereview.appspot.com/115089/diff/1/2 > File src/com/google/caja/plugin/stages/ConsolidateCodeStage.java (right): > > http://codereview.appspot.com/115089/diff/1/2#newcode20 > ...
16 years, 6 months ago (2009-09-10 22:06:28 UTC) #3
MikeSamuel
LGTM
16 years, 6 months ago (2009-09-10 22:10:02 UTC) #4
felix8a
16 years, 6 months ago (2009-09-24 19:44:22 UTC) #5
On 2009/09/10 22:10:02, MikeSamuel wrote:
> LGTM

@r3723
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b