onclick= set by innerHTML is broken

http://code.google.com/p/google-caja/issues/detail?id=588

domita has support for setting very simple onevent= handlers
when assigning to innerHTML.  for example, this is supposed
to work:

  <div id='a'></div>
  <script>
    var a = document.getElementById('a');
    a.innerHTML = '<input type="button" onclick="foo();">';
    function foo () { cajita.log(1); }
  </script>

however, this has been broken since valija was created,
because plugin_dispatchEvent knows how to find a cajita 'foo',
but not a valija 'foo'.

this change teaches plugin_dispatchEvent about valija 'foo'.

[MikeSamuel, 2009-09-10 17:26:41]

http://codereview.appspot.com/115082/diff/1/3
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/115082/diff/1/3#newcode4050
Line 4050: handler = imports.$v ? imports.$v.ro(handler) : imports[handler];
Maybe (___.canRead(imports, '$v') && imports.$v.ro(handler))
      || ___.readPub(imports, handler);

[felix8a, 2009-09-10 21:19:39]

On 2009/09/10 17:26:41, MikeSamuel wrote:
> http://codereview.appspot.com/115082/diff/1/3
> File src/com/google/caja/plugin/domita.js (right):
> 
> http://codereview.appspot.com/115082/diff/1/3#newcode4050
> Line 4050: handler = imports.$v ? imports.$v.ro(handler) : imports[handler];
> Maybe (___.canRead(imports, '$v') && imports.$v.ro(handler))
>       || ___.readPub(imports, handler);

ok.  updated snapshot.

[MikeSamuel, 2009-09-10 21:36:07]

http://codereview.appspot.com/115082/diff/5/6
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/115082/diff/5/6#newcode30
Line 30: <p class="clickme-testcontainer" id="test-add-event-listener">
What is this clickme-testcontainer?
I see the code in DomitaTest which checks
      clickingList =
          driver.findElements(By.xpath("//*[contains(@class,'clickme')]/*"));

but there should be a space between clickme and testcontainer instead of a dash.

Hmm.  But not a problem for this CL.

[MikeSamuel, 2009-09-10 21:36:16]

LGTM

[felix8a, 2009-09-10 21:55:46]

On 2009/09/10 21:36:07, MikeSamuel wrote:
> http://codereview.appspot.com/115082/diff/5/6
> File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
> 
> http://codereview.appspot.com/115082/diff/5/6#newcode30
> Line 30: <p class="clickme-testcontainer" id="test-add-event-listener">
> What is this clickme-testcontainer?
> I see the code in DomitaTest which checks
>       clickingList =
>           driver.findElements(By.xpath("//*[contains(@class,'clickme')]/*"));
> 
> but there should be a space between clickme and testcontainer instead of a
dash.
> 
> Hmm.  But not a problem for this CL.

xpath 'contains' is a substring search, not a word search.
afaik, xpath doesn't have a word search.

[felix8a, 2009-09-10 22:08:37]

On 2009/09/10 21:36:16, MikeSamuel wrote:
> LGTM

@r3722