Issue 11507048: Added testcase for issue 1804 -- extraneous commas and brackets in selectors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11507048: Added testcase for issue 1804 -- extraneous commas and brackets in selectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by MikeSamuel

Modified:
12 years, 7 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

https://code.google.com/p/google-caja/issues/detail?id=1804 > lexCss/sanitizeCssSelectors will not handle the following cases correctly: > "a," or ",a" or "," -- drops comma silently > "bad[" -- throws an internal error rather than invoking > opt_onUntranslatableSelector Submitted @ r5502

Patch Set 1 #

Patch Set 2 : Added testcase for issue 1804 -- extraneous commas and brackets in selectors #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
M	src/com/google/caja/plugin/sanitizecss.js	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/CssLexerTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/csslexer-test.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/sanitizecss_test.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

https://code.google.com/p/google-caja/issues/detail?id=1804 > lexCss/sanitizeCssSelectors will not handle the following cases correctly: > "a," or ",a" or ...

12 years, 7 months ago (2013-07-24 17:52:08 UTC) #2

lgtm

Expand All Messages | Collapse All Messages