Issue 11486044: upgrade selenium/webdriver

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11486044: upgrade selenium/webdriver (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by felix8a

Modified:
12 years, 7 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

this is a build from selenium trunk, because it includes a fix that allows js execution to work in firefox again. how to rebuild: git clone https://code.google.com/p/selenium/ cd selenium git checkout bb3450e3ab26 ./go selenium-server-standalone

Patch Set 1 #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -4 lines)			Patch
M	build.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/java/webdriver/README	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	third_party/java/webdriver/VERSION	View	1 chunk	+2 lines, -2 lines	1 comment	Download
D	third_party/java/webdriver/selenium-server-standalone-2.33.0.jar	View	Binary file		0 comments	Download
A	third_party/java/webdriver/selenium-standalone.jar	View	Binary file		0 comments	Download
	third_party/java/webdriver/selenium-standalone.jar	View	0 chunks	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kpreid2

LGTM https://codereview.appspot.com/11486044/diff/1/third_party/java/webdriver/VERSION File third_party/java/webdriver/VERSION (right): https://codereview.appspot.com/11486044/diff/1/third_party/java/webdriver/VERSION#newcode1 third_party/java/webdriver/VERSION:1: Version: bb3450e3ab26 (2013-07-22 trunk after 2.33.0) Maybe use ...

12 years, 7 months ago (2013-07-23 20:31:11 UTC) #2

felix8a

12 years, 7 months ago (2013-07-23 23:19:23 UTC) #3

@r5500

On 2013/07/23 20:31:11, kpreid2 wrote:
> LGTM
> 
>
https://codereview.appspot.com/11486044/diff/1/third_party/java/webdriver/VER...
> File third_party/java/webdriver/VERSION (right):
> 
>
https://codereview.appspot.com/11486044/diff/1/third_party/java/webdriver/VER...
> third_party/java/webdriver/VERSION:1: Version: bb3450e3ab26 (2013-07-22 trunk
> after 2.33.0)
> Maybe use `git describe`'s answer here, as a standard format? In this case it
> is:
> 
>     selenium-2.29.0a-830-gbb3450e

yeah, that's slightly odd and maybe misleading, 2.29.0a was a long time ago.

Expand All Messages | Collapse All Messages