Issue 114820044: Fix deprecated gtk3 GtkMisc, GtkAlignment and vala Gdk.X11Display

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 114820044: Fix deprecated gtk3 GtkMisc, GtkAlignment and vala Gdk.X11Display (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by fujiwara

Modified:
9 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix deprecated gtk3 GtkMisc, GtkAlignment and vala Gdk.X11Display gtk 3.13.4 warns GtkMisc and GtkAlignment vala 0.24 warns Gdk.X11Display https://git.gnome.org/browse/gtk+/commit/?id=ec0a60a248 https://git.gnome.org/browse/gtk+/commit/?id=04703689b8 https://git.gnome.org/browse/vala/commit/?id=b65e3dc87c TEST=make ui/gtk3

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -17 lines)			Patch
M	ui/gtk3/candidatearea.vala	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	ui/gtk3/candidatepanel.vala	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ui/gtk3/keybindingmanager.vala	View	3 chunks	+14 lines, -0 lines	0 comments	Download
M	ui/gtk3/propertypanel.vala	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	ui/gtk3/switcher.vala	View	4 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2014/07/16 14:42:15, fujiwara wrote:

lgtm

Expand All Messages | Collapse All Messages