Use guice-multibindings for Template TagHandlers

[johnfargo, 2010-05-07 04:30:57]

http://codereview.appspot.com/1147041/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/3#newcode91
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java:91:
};
no change in this file (except whitespace)?

http://codereview.appspot.com/1147041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/4#newcode24
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:24:
import com.google.inject.multibindings.Multibinder;
ordering... right?

http://codereview.appspot.com/1147041/diff/1/4#newcode54
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:54:
tagBinder.addBinding().to(VariableTagHandler.class);
I can see the value here when adding multiple bindings from different sources,
but is there much vs. the previous model in this case?

[Paul Lindner, 2010-05-07 14:51:23]

http://codereview.appspot.com/1147041/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/3#newcode91
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java:91:
};
On 2010/05/07 04:30:58, johnfargo wrote:
> no change in this file (except whitespace)?

Done.

http://codereview.appspot.com/1147041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java
(right):

http://codereview.appspot.com/1147041/diff/1/4#newcode24
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:24:
import com.google.inject.multibindings.Multibinder;
On 2010/05/07 04:30:58, johnfargo wrote:
> ordering... right?

Done.

http://codereview.appspot.com/1147041/diff/1/4#newcode54
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:54:
tagBinder.addBinding().to(VariableTagHandler.class);
On 2010/05/07 04:30:58, johnfargo wrote:
> I can see the value here when adding multiple bindings from different sources,
> but is there much vs. the previous model in this case?

About the same.  I believe that using a multibinding is simpler than subclassing
and overriding a module.

[johnfargo, 2010-05-07 15:26:26]

lgtm

On Fri, May 7, 2010 at 7:51 AM, <lindner@inuus.com> wrote:

>
> http://codereview.appspot.com/1147041/diff/1/3
> File
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
> (right):
>
> http://codereview.appspot.com/1147041/diff/1/3#newcode91
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java:91:
> };
> On 2010/05/07 04:30:58, johnfargo wrote:
>
>> no change in this file (except whitespace)?
>>
>
> Done.
>
>
> http://codereview.appspot.com/1147041/diff/1/4
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java
> (right):
>
> http://codereview.appspot.com/1147041/diff/1/4#newcode24
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:24:
> import com.google.inject.multibindings.Multibinder;
> On 2010/05/07 04:30:58, johnfargo wrote:
>
>> ordering... right?
>>
>
> Done.
>
>
> http://codereview.appspot.com/1147041/diff/1/4#newcode54
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java:54:
> tagBinder.addBinding().to(VariableTagHandler.class);
> On 2010/05/07 04:30:58, johnfargo wrote:
>
>> I can see the value here when adding multiple bindings from different
>>
> sources,
>
>> but is there much vs. the previous model in this case?
>>
>
> About the same.  I believe that using a multibinding is simpler than
> subclassing and overriding a module.
>
>
> http://codereview.appspot.com/1147041/show
>