Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 11470043: fix client-side parsing of minified css (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by felix8a
Modified:
12 years, 7 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The client-side css parser has a couple problems handling minified css. 1. ruleset() always skips the token following the selector, which is expected to be '{', even if it isn't a '{'. This screws up parsing of problems like @foo{x}y{...} because the x is a selector and the '}' gets skipped, so the y gets absorbed into @foo. 2. ruleset() always skips the token following the closing '}'. This is harmless if the token is whitespace, but screws up but if the next statement is not separated by whitespace. This fixes https://code.google.com/p/google-caja/issues/detail?id=1770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M src/com/google/caja/plugin/cssparser.js View 2 chunks +8 lines, -9 lines 0 comments Download
M tests/com/google/caja/plugin/cssparser_test.js View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 7 months ago (2013-07-17 19:43:58 UTC) #1
MikeSamuel
On 2013/07/17 19:43:58, felix8a wrote: LGTM
12 years, 7 months ago (2013-07-17 22:06:39 UTC) #2
felix8a
12 years, 7 months ago (2013-07-17 22:10:49 UTC) #3
@r5498
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b